From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 90B8E6B01F0 for ; Sun, 29 Aug 2010 11:42:29 -0400 (EDT) Received: by pwj6 with SMTP id 6so1972390pwj.14 for ; Sun, 29 Aug 2010 08:42:28 -0700 (PDT) Date: Mon, 30 Aug 2010 00:42:21 +0900 From: Minchan Kim Subject: Re: [PATCH] vmscan: fix missing place to check nr_swap_pages. Message-ID: <20100829154221.GB2714@barrios-desktop> References: <1282867897-31201-1-git-send-email-yinghan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org To: Venkatesh Pallipadi Cc: Ying Han , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rik van Riel , KOSAKI Motohiro List-ID: On Fri, Aug 27, 2010 at 06:30:58PM -0700, Venkatesh Pallipadi wrote: > On Fri, Aug 27, 2010 at 9:35 AM, Ying Han wrote: > > In our system, we do have swap configured. In vmscan.c, there are > > couple of places where we skip scanning > > and shrinking anon lru while the condition if(nr_swap_pages <= 0) is > > true. It still make sense to me to add it > > to the shrink_active() condition as the initial patch. > > > > Also, we found it is quite often to hit the condition > > inactive_anon_is_low on machine with small numa node size, since the > > zone->inactive_ratio is set based on the zone->present_pages. > > > > Does "total_swap_pages" help? Yes. Thanks for advising. > > Thanks, > Venki -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org