From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Neil Brown <neilb@suse.de>
Cc: kosaki.motohiro@jp.fujitsu.com,
Wu Fengguang <fengguang.wu@intel.com>,
Con Kolivas <kernel@kolivas.org>, Jan Kara <jack@suse.cz>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio
Date: Thu, 26 Aug 2010 13:22:02 +0900 (JST) [thread overview]
Message-ID: <20100826132046.F670.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100826113649.687b453a@notabene>
> > writeback: remove the internal 5% low bound on dirty_ratio
> >
> > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%.
> > This is not a user expected behavior. And it's inconsistent with
> > calc_period_shift(), which uses the plain vm_dirty_ratio value.
> >
> > Let's rip the internal bound.
> >
> > At the same time, fix balance_dirty_pages() to work with the
> > dirty_thresh=0 case. This allows applications to proceed when
> > dirty+writeback pages are all cleaned.
>
> And ">" fits with the name "exceeded" better than ">=" does. I think it is
> an aesthetic improvement as well as a functional one.
>
> Reviewed-by: NeilBrown <neilb@suse.de>
I agree :)
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-26 4:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 3:25 Wu Fengguang
2010-08-20 3:46 ` Rik van Riel
2010-08-20 4:13 ` KOSAKI Motohiro
2010-08-20 5:50 ` Con Kolivas
2010-08-20 5:56 ` Wu Fengguang
2010-08-23 4:42 ` Neil Brown
2010-08-23 6:23 ` Wu Fengguang
2010-08-23 6:30 ` Con Kolivas
2010-08-23 7:15 ` Wu Fengguang
2010-08-24 0:00 ` KOSAKI Motohiro
[not found] ` <201008241620.54048.kernel@kolivas.org>
[not found] ` <20100824071440.GA14598@localhost>
[not found] ` <201008251840.00532.kernel@kolivas.org>
2010-08-26 1:29 ` Wu Fengguang
2010-08-26 1:36 ` Neil Brown
2010-08-26 4:22 ` KOSAKI Motohiro [this message]
2010-08-27 10:36 Wu Fengguang
2010-08-27 10:39 ` Peter Zijlstra
2010-08-27 13:47 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826132046.F670.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kernel@kolivas.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox