From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 399916B01F0 for ; Tue, 24 Aug 2010 20:00:22 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o7P03lwD031586 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Wed, 25 Aug 2010 09:03:48 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id E2A1445DE4D for ; Wed, 25 Aug 2010 09:03:46 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id B5C2B45DE50 for ; Wed, 25 Aug 2010 09:03:46 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 9C1E81DB8054 for ; Wed, 25 Aug 2010 09:03:46 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 4A7461DB8050 for ; Wed, 25 Aug 2010 09:03:46 +0900 (JST) Date: Wed, 25 Aug 2010 08:58:43 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/5] cgroup: ID notification call back Message-Id: <20100825085843.54277f3c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <4C738B34.6070602@cn.fujitsu.com> References: <20100820185552.426ff12e.kamezawa.hiroyu@jp.fujitsu.com> <20100820185816.1dbcd53a.kamezawa.hiroyu@jp.fujitsu.com> <4C738B34.6070602@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Li Zefan Cc: linux-mm@kvack.org, "nishimura@mxp.nes.nec.co.jp" , "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , kamezawa.hiroyuki@gmail.com, "menage@google.com" List-ID: On Tue, 24 Aug 2010 17:04:52 +0800 Li Zefan wrote: > KAMEZAWA Hiroyuki wrote: > > CC'ed to Paul Menage and Li Zefan. > > == > > From: KAMEZAWA Hiroyuki > > > > When cgroup subsystem use ID (ss->use_id==1), each css's ID is assigned > > after successful call of ->create(). css_ID is tightly coupled with > > css struct itself but it is allocated by ->create() call, IOW, > > per-subsystem special allocations. > > > > To know css_id before creation, this patch adds id_attached() callback. > > after css_ID allocation. This will be used by memory cgroup's quick lookup > > routine. > > > > Maybe you can think of other implementations as > > - pass ID to ->create() > > or > > - add post_create() > > etc... > > But when considering dirtiness of codes, this straightforward patch seems > > good to me. If someone wants post_create(), this patch can be replaced. > > > > Changelog: 20100820 > > - new approarch. > > > > Signed-off-by: KAMEZAWA Hiroyuki > > Acked-by: Li Zefan > > ... > > > > Index: mmotm-0811/include/linux/cgroup.h > > =================================================================== > > --- mmotm-0811.orig/include/linux/cgroup.h > > +++ mmotm-0811/include/linux/cgroup.h > > @@ -475,6 +475,7 @@ struct cgroup_subsys { > > struct cgroup *cgrp); > > void (*post_clone)(struct cgroup_subsys *ss, struct cgroup *cgrp); > > void (*bind)(struct cgroup_subsys *ss, struct cgroup *root); > > + void (*id_attached)(struct cgroup_subsys *ss, struct cgroup *cgrp); > > Maybe pass the id number to id_attached() is better. > ok. > And actually the @ss argument is not necessary, because the memcg's > id_attached() handler of course knows it's dealing with the memory > cgroup subsystem. > > So I suspect we can just remove all the @ss from all the callbacks.. > I agree. But could you write "remove ss" patch later ? It seems an design change. I leave "ss" as this for now. Thanks -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org