From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-mm@kvack.org,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
gthelen@google.com, m-ikeda@ds.jp.nec.com,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kamezawa.hiroyuki@gmail.com
Subject: Re: [PATCH 4/5] memcg: lockless update of file_mapped
Date: Tue, 24 Aug 2010 09:19:22 +0900 [thread overview]
Message-ID: <20100824091922.ae133d72.nishimura@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20100824084916.078d6a82.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, 24 Aug 2010 08:49:16 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Mon, 23 Aug 2010 17:50:15 +0900
> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>
> > This patch looks good to me, but I have one question.
> >
> > Why do we need to acquire sc.lock inside mem_cgroup_(start|end)_move() ?
> > These functions doesn't access mc.*.
> >
>
> just reusing a lock to update status. If you don't like, I'll add a new lock.
>
I see. I think it would be enough just to add some comments about it.
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-24 0:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 9:55 [PATCH] memcg: towards I/O aware memcg v5 KAMEZAWA Hiroyuki
2010-08-20 9:58 ` [PATCH 1/5] cgroup: ID notification call back KAMEZAWA Hiroyuki
2010-08-24 7:19 ` Greg Thelen
2010-08-24 7:18 ` KAMEZAWA Hiroyuki
2010-08-24 9:04 ` Li Zefan
2010-08-24 23:58 ` KAMEZAWA Hiroyuki
2010-08-25 0:11 ` Paul Menage
2010-08-25 0:17 ` KAMEZAWA Hiroyuki
2010-08-25 0:25 ` Paul Menage
2010-08-25 0:09 ` Paul Menage
2010-08-25 0:20 ` KAMEZAWA Hiroyuki
2010-08-25 0:34 ` Paul Menage
2010-08-25 0:37 ` KAMEZAWA Hiroyuki
2010-08-25 0:46 ` Paul Menage
2010-08-25 1:03 ` KAMEZAWA Hiroyuki
2010-08-25 1:35 ` Paul Menage
2010-08-25 1:42 ` KAMEZAWA Hiroyuki
2010-08-25 1:52 ` Paul Menage
2010-08-25 2:29 ` KAMEZAWA Hiroyuki
2010-08-20 9:59 ` [PATCH 2/5] memcg: use array and ID for quick look up KAMEZAWA Hiroyuki
2010-08-23 3:35 ` Daisuke Nishimura
2010-08-23 23:51 ` KAMEZAWA Hiroyuki
2010-08-24 0:19 ` Daisuke Nishimura
2010-08-24 7:44 ` Greg Thelen
2010-08-24 7:42 ` KAMEZAWA Hiroyuki
2010-08-20 10:01 ` [PATCH] memcg: use ID in page_cgroup KAMEZAWA Hiroyuki
2010-08-23 5:32 ` Daisuke Nishimura
2010-08-23 23:52 ` KAMEZAWA Hiroyuki
2010-08-24 1:14 ` Daisuke Nishimura
2010-08-24 1:54 ` KAMEZAWA Hiroyuki
2010-08-24 4:04 ` Daisuke Nishimura
2010-08-24 6:05 ` KAMEZAWA Hiroyuki
2010-08-24 7:47 ` Greg Thelen
2010-08-24 7:51 ` KAMEZAWA Hiroyuki
2010-08-24 8:35 ` Greg Thelen
2010-08-24 8:38 ` KAMEZAWA Hiroyuki
2010-08-20 10:02 ` [PATCH 4/5] memcg: lockless update of file_mapped KAMEZAWA Hiroyuki
2010-08-23 8:50 ` Daisuke Nishimura
2010-08-23 23:49 ` KAMEZAWA Hiroyuki
2010-08-24 0:19 ` Daisuke Nishimura [this message]
2010-08-20 10:03 ` [PATCH 5/5] memcg: generic file accounting update function KAMEZAWA Hiroyuki
2010-08-24 7:46 ` [PATCH] memcg: towards I/O aware memcg v5 Balbir Singh
2010-08-24 7:59 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824091922.ae133d72.nishimura@mxp.nes.nec.co.jp \
--to=nishimura@mxp.nes.nec.co.jp \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kamezawa.hiroyuki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m-ikeda@ds.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox