From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 099D56B03B0 for ; Mon, 23 Aug 2010 08:16:45 -0400 (EDT) From: Nikanth Karthikesan Subject: Re: [RFC][PATCH] Per file dirty limit throttling Date: Mon, 23 Aug 2010 17:49:19 +0530 References: <201008160949.51512.knikanth@suse.de> <201008181452.05047.knikanth@suse.de> <1282125536.1926.3675.camel@laptop> In-Reply-To: <1282125536.1926.3675.camel@laptop> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201008231749.19836.knikanth@suse.de> Sender: owner-linux-mm@kvack.org To: Peter Zijlstra Cc: Wu Fengguang , Bill Davidsen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Andrew Morton , Jan Kara List-ID: On Wednesday 18 August 2010 15:28:56 Peter Zijlstra wrote: > On Wed, 2010-08-18 at 14:52 +0530, Nikanth Karthikesan wrote: > > On Tuesday 17 August 2010 13:54:35 Peter Zijlstra wrote: > > > On Tue, 2010-08-17 at 10:39 +0530, Nikanth Karthikesan wrote: > > > > Oh, nice. Per-task limit is an elegant solution, which should help > > > > during most of the common cases. > > > > > > > > But I just wonder what happens, when > > > > 1. The dirtier is multiple co-operating processes > > > > 2. Some app like a shell script, that repeatedly calls dd with seek > > > > and skip? People do this for data deduplication, sparse skipping > > > > etc.. 3. The app dies and comes back again. Like a VM that is > > > > rebooted, and continues writing to a disk backed by a file on the > > > > host. > > > > > > > > Do you think, in those cases this might still be useful? > > > > > > Those cases do indeed defeat the current per-task-limit, however I > > > think the solution to that is to limit the amount of writeback done by > > > each blocked process. > > > > Blocked on what? Sorry, I do not understand. > > balance_dirty_pages(), by limiting the work done there (or actually, the > amount of page writeback completions you wait for -- starting IO isn't > that expensive), you can also affect the time it takes, and therefore > influence the impact. > But this has nothing special to do with the cases like multi-threaded dirtier, which is why I was confused. :) Thanks Nikanth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org