From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 8D9726B03DB for ; Mon, 23 Aug 2010 13:06:31 -0400 (EDT) Received: by pwi3 with SMTP id 3so2812290pwi.14 for ; Mon, 23 Aug 2010 10:06:16 -0700 (PDT) Date: Tue, 24 Aug 2010 02:06:10 +0900 From: Minchan Kim Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting Message-ID: <20100823170610.GB2304@barrios-desktop> References: <1282580114-2136-1-git-send-email-minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Andrew Morton , Linux Kernel List , linux-mm@kvack.org, Hugh Dickins , Andi Kleen , Mel Gorman List-ID: On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: > On Tue, 24 Aug 2010, Minchan Kim wrote > > > This patch introude new argument 'cleanup' to migrate_pages. > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. > > Otherwise, caller need to clean up the lists so it has a chance to postprocess > > the pages. > > Could we simply make migrate_pages simply not do any cleanup? > Caller has to call putback_lru_pages()? > Hmm. maybe I misunderstood your point. Your point is that let's make whole caller of migrate_pagse has a responsibility of clean up the list? -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org