From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 88B706B0315 for ; Fri, 20 Aug 2010 06:08:47 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o7KA8jZG020263 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Fri, 20 Aug 2010 19:08:45 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id F149145DE50 for ; Fri, 20 Aug 2010 19:08:44 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id D3B1F45DE4F for ; Fri, 20 Aug 2010 19:08:44 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id BB5AD1DB8050 for ; Fri, 20 Aug 2010 19:08:44 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 74E2B1DB8048 for ; Fri, 20 Aug 2010 19:08:41 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 2/4] mm: account_page_writeback added In-Reply-To: <20100820094525.GB8440@localhost> References: <1282296689-25618-3-git-send-email-mrubin@google.com> <20100820094525.GB8440@localhost> Message-Id: <20100820190803.6009.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Fri, 20 Aug 2010 19:08:40 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: kosaki.motohiro@jp.fujitsu.com, Michael Rubin , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "jack@suse.cz" , "riel@redhat.com" , "akpm@linux-foundation.org" , "david@fromorbit.com" , "npiggin@kernel.dk" , "hch@lst.de" , "axboe@kernel.dk" List-ID: > I'm not sure this should be an inline function, just a reminder. > Even with one more inc_zone_page_state() in next patch. > > > +void account_page_writeback(struct page *page) > > +{ > > + inc_zone_page_state(page, NR_WRITEBACK); > > +} > > +EXPORT_SYMBOL(account_page_writeback); Personally, I like inline. but it's no big matter. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org