From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Michael Rubin <mrubin@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
fengguang.wu@intel.com, jack@suse.cz, riel@redhat.com,
akpm@linux-foundation.org, david@fromorbit.com,
npiggin@kernel.dk, hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH 3/4] writeback: nr_dirtied and nr_entered_writeback in /proc/vmstat
Date: Fri, 20 Aug 2010 19:05:39 +0900 (JST) [thread overview]
Message-ID: <20100820190329.6000.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1282296689-25618-4-git-send-email-mrubin@google.com>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index f389168..073a496 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -732,6 +732,9 @@ static const char * const vmstat_text[] = {
> "nr_isolated_anon",
> "nr_isolated_file",
> "nr_shmem",
> + "nr_dirtied",
> + "nr_entered_writeback",
> +
> #ifdef CONFIG_NUMA
> "numa_hit",
> "numa_miss",
'nr_entered_writeback' seems ok. but nr_dirtied seems a bit easy confusable
with 'nr_dirty'. Can you please choice more clear meaningful name?
Otherwise looks good to me.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-20 10:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 9:31 [PATCH 0/4] writeback: kernel visibility Michael Rubin
2010-08-20 9:31 ` [PATCH 1/4] mm: exporting account_page_dirty Michael Rubin
2010-08-20 9:39 ` Wu Fengguang
2010-08-20 15:37 ` Sage Weil
2010-08-20 9:31 ` [PATCH 2/4] mm: account_page_writeback added Michael Rubin
2010-08-20 9:45 ` Wu Fengguang
2010-08-20 10:08 ` KOSAKI Motohiro
2010-08-20 9:31 ` [PATCH 3/4] writeback: nr_dirtied and nr_entered_writeback in /proc/vmstat Michael Rubin
2010-08-20 10:05 ` KOSAKI Motohiro [this message]
2010-08-20 10:08 ` Wu Fengguang
2010-08-20 23:51 ` Michael Rubin
2010-08-21 0:48 ` Wu Fengguang
2010-08-23 17:45 ` Michael Rubin
2010-08-24 2:30 ` Wu Fengguang
2010-08-24 3:02 ` Michael Rubin
2010-08-24 3:25 ` Wu Fengguang
2010-08-20 9:31 ` [PATCH 4/4] writeback: Reporting dirty thresholds " Michael Rubin
2010-08-20 10:06 ` KOSAKI Motohiro
2010-08-22 10:27 ` KOSAKI Motohiro
2010-08-20 10:12 ` Wu Fengguang
2010-08-21 5:48 ` Wu Fengguang
2010-08-23 17:52 ` Michael Rubin
2010-08-24 1:20 ` KOSAKI Motohiro
2010-08-24 1:41 ` Michael Rubin
2010-08-24 2:11 ` Wu Fengguang
2010-08-24 2:42 ` Michael Rubin
2010-08-24 2:01 ` Wu Fengguang
2010-08-24 2:04 ` Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820190329.6000.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox