From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] oom: fix tasklist_lock leak
Date: Fri, 20 Aug 2010 08:52:24 +0900 [thread overview]
Message-ID: <20100820085224.ca96c878.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20100819195346.5FCA.A69D9226@jp.fujitsu.com>
On Thu, 19 Aug 2010 19:54:06 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> commit 0aad4b3124 (oom: fold __out_of_memory into out_of_memory)
> introduced tasklist_lock leak. Then it caused following obvious
> danger warings and panic.
>
> ================================================
> [ BUG: lock held when returning to user space! ]
> ------------------------------------------------
> rsyslogd/1422 is leaving the kernel with locks still held!
> 1 lock held by rsyslogd/1422:
> #0: (tasklist_lock){.+.+.+}, at: [<ffffffff810faf64>] out_of_memory+0x164/0x3f0
> BUG: scheduling while atomic: rsyslogd/1422/0x00000002
> INFO: lockdep is turned off.
>
> This patch fixes it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-08-19 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 10:52 [PATCH 0/2] oom: Fix two critical bug in 2.6.36-rc1 KOSAKI Motohiro
2010-08-19 10:53 ` [PATCH 1/2] oom: fix NULL pointer dereference KOSAKI Motohiro
2010-08-19 15:29 ` Minchan Kim
2010-08-19 20:35 ` David Rientjes
2010-08-19 23:50 ` KAMEZAWA Hiroyuki
2010-08-19 10:54 ` [PATCH 2/2] oom: fix tasklist_lock leak KOSAKI Motohiro
2010-08-19 16:05 ` Minchan Kim
2010-08-19 20:37 ` David Rientjes
2010-08-19 23:52 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820085224.ca96c878.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox