* Re: [PATCH] mm: code improvement of check_stack_guard_page
[not found] <AANLkTinfgXOzbqgrRY4oCGXFtKtEyJO_rvQeeEEeEZz7@mail.gmail.com>
@ 2010-08-18 2:02 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; only message in thread
From: KAMEZAWA Hiroyuki @ 2010-08-18 2:02 UTC (permalink / raw)
To: jovi zhang
Cc: torvalds, akpm, hughd, riel, minchan.kim, linux-mm, linux-kernel
On Sun, 15 Aug 2010 13:07:56 +0800
jovi zhang <bookjovi@gmail.com> wrote:
> little code improvement of check_stack_guard_page function.
> this commit is on top of commit "mm: keep a guard page below a grow-down
> stack segment" of linus.
>
Hmm. difference in binary code finally ?
-Kame
> diff --git a/mm/memory.c b/mm/memory.c
> index 9b3b73f..643b112 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2768,13 +2768,15 @@ out_release:
> */
> static inline int check_stack_guard_page(struct vm_area_struct *vma,
> unsigned long address)
> {
> - address &= PAGE_MASK;
> - if ((vma->vm_flags & VM_GROWSDOWN) && address == vma->vm_start) {
> - address -= PAGE_SIZE;
> - if (find_vma(vma->vm_mm, address) != vma)
> - return -ENOMEM;
> -
> - expand_stack(vma, address);
> + if (vma->vm_flags & VM_GROWSDOWN) {
> + address &= PAGE_MASK;
> + if(address == vma->vm_start) {
> + address -= PAGE_SIZE;
> + if (unlikely(find_vma(vma->vm_mm, address) != vma))
> + return -ENOMEM;
> +
> + expand_stack(vma, address);
> + }
> }
> return 0;
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] only message in thread