From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 797AB6B02AA for ; Thu, 5 Aug 2010 02:14:39 -0400 (EDT) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o756EmlE008682 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Thu, 5 Aug 2010 15:14:49 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id BFE2C45DE52 for ; Thu, 5 Aug 2010 15:14:48 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 8BEAA45DE54 for ; Thu, 5 Aug 2010 15:14:48 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 6AF151DB805D for ; Thu, 5 Aug 2010 15:14:48 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id DF6C31DB8060 for ; Thu, 5 Aug 2010 15:14:47 +0900 (JST) From: KOSAKI Motohiro Subject: [PATCH 5/7] vmscan: kill dead code in shrink_inactive_list() In-Reply-To: <20100805150624.31B7.A69D9226@jp.fujitsu.com> References: <20100805150624.31B7.A69D9226@jp.fujitsu.com> Message-Id: <20100805151415.31C6.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Thu, 5 Aug 2010 15:14:47 +0900 (JST) Sender: owner-linux-mm@kvack.org To: LKML , linux-mm , Andrew Morton , Johannes Weiner , Mel Gorman , Wu Fengguang , Minchan Kim , Rik van Riel Cc: kosaki.motohiro@jp.fujitsu.com List-ID: When synchrounous lumy reclaim occur, page_list have gurantee to don't have active page because now page activation in shrink_page_list() always disable lumpy reclaim. Then, This patch remove virtual dead code. Signed-off-by: KOSAKI Motohiro --- mm/vmscan.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index f7aabd2..f21dbeb 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1334,7 +1334,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, unsigned long nr_scanned; unsigned long nr_reclaimed = 0; unsigned long nr_taken; - unsigned long nr_active; unsigned long nr_anon; unsigned long nr_file; @@ -1389,13 +1388,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, /* Check if we should syncronously wait for writeback */ if (should_reclaim_stall(nr_taken, nr_reclaimed, priority, sc)) { - /* - * The attempt at page out may have made some - * of the pages active, mark them inactive again. - */ - nr_active = clear_active_flags(&page_list, NULL); - count_vm_events(PGDEACTIVATE, nr_active); - set_lumpy_reclaim_mode(priority, sc, true); nr_reclaimed += shrink_page_list(&page_list, sc); } -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org