From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 2F0E26006B4 for ; Mon, 19 Jul 2010 21:58:47 -0400 (EDT) Date: Tue, 20 Jul 2010 10:47:58 +0900 From: Daisuke Nishimura Subject: Re: [PATCH 0/7] memcg reclaim tracepoint Message-Id: <20100720104758.376c4fc7.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20100716191006.7369.A69D9226@jp.fujitsu.com> References: <20100716191006.7369.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Nishimura Daisuke , Daisuke Nishimura List-ID: On Fri, 16 Jul 2010 19:12:46 +0900 (JST) KOSAKI Motohiro wrote: > Recently, Mel Gorman added some vmscan tracepoint. but they can't > trace memcg. So, This patch series does. > > > following three patches are nit fix and cleanups. > > memcg: sc.nr_to_reclaim should be initialized > memcg: mem_cgroup_shrink_node_zone() doesn't need sc.nodemask > memcg: nid and zid can be calculated from zone > I'm not so familiar with tracepoints, but I don't have any objection to these 3 fix/cleanup for memcg. Thanks, Daisuke Nishimura > following four patches are tracepoint conversion and adding memcg tracepoints. > > vmscan: convert direct reclaim tracepoint to DEFINE_EVENT > memcg, vmscan: add memcg reclaim tracepoint > vmscan: convert mm_vmscan_lru_isolate to DEFINE_EVENT > memcg, vmscan: add mm_vmscan_memcg_isolate tracepoint > > > diffstat > ================ > include/linux/memcontrol.h | 6 ++-- > include/linux/mmzone.h | 5 +++ > include/linux/swap.h | 3 +- > include/trace/events/vmscan.h | 79 +++++++++++++++++++++++++++++++++++++++-- > mm/memcontrol.c | 15 +++++--- > mm/vmscan.c | 35 ++++++++++++------ > 6 files changed, 118 insertions(+), 25 deletions(-) > > > Sameple output is here. > ========================= > > dd-1851 [001] 158.837763: mm_vmscan_memcg_reclaim_begin: order=0 may_writepage=1 gfp_flags=GFP_HIGHUSER_MOVABLE > dd-1851 [001] 158.837783: mm_vmscan_memcg_isolate: isolate_mode=0 order=0 nr_requested=32 nr_scanned=32 nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > dd-1851 [001] 158.837860: mm_vmscan_memcg_reclaim_end: nr_reclaimed=32 > (...) > dd-1970 [000] 266.608235: mm_vmscan_wakeup_kswapd: nid=0 zid=1 order=0 > dd-1970 [000] 266.608239: mm_vmscan_wakeup_kswapd: nid=1 zid=1 order=0 > dd-1970 [000] 266.608248: mm_vmscan_wakeup_kswapd: nid=2 zid=1 order=0 > kswapd1-348 [001] 266.608254: mm_vmscan_kswapd_wake: nid=1 order=0 > dd-1970 [000] 266.608254: mm_vmscan_wakeup_kswapd: nid=3 zid=1 order=0 > kswapd3-350 [000] 266.608266: mm_vmscan_kswapd_wake: nid=3 order=0 > (...) > kswapd0-347 [001] 267.328891: mm_vmscan_memcg_softlimit_reclaim_begin: order=0 may_writepage=1 gfp_flags=GFP_HIGHUSER_MOVABLE > kswapd0-347 [001] 267.328897: mm_vmscan_memcg_isolate: isolate_mode=0 order=0 nr_requested=32 nr_scanned=32 nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > kswapd0-347 [001] 267.328915: mm_vmscan_memcg_isolate: isolate_mode=0 order=0 nr_requested=32 nr_scanned=32 nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > kswapd0-347 [001] 267.328989: mm_vmscan_memcg_softlimit_reclaim_end: nr_reclaimed=32 > kswapd0-347 [001] 267.329019: mm_vmscan_lru_isolate: isolate_mode=1 order=0 nr_requested=32 nr_scanned=32 nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > kswapd0-347 [001] 267.330562: mm_vmscan_lru_isolate: isolate_mode=1 order=0 nr_requested=32 nr_scanned=32 nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > (...) > kswapd2-349 [001] 267.407081: mm_vmscan_kswapd_sleep: nid=2 > kswapd3-350 [001] 267.408077: mm_vmscan_kswapd_sleep: nid=3 > kswapd1-348 [000] 267.427858: mm_vmscan_kswapd_sleep: nid=1 > kswapd0-347 [001] 267.430064: mm_vmscan_kswapd_sleep: nid=0 > > > > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org