From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id C27826B02A4 for ; Fri, 16 Jul 2010 06:21:49 -0400 (EDT) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o6GALlpn010979 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 16 Jul 2010 19:21:47 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 2D83845DE4F for ; Fri, 16 Jul 2010 19:21:47 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 0A39F45DE4C for ; Fri, 16 Jul 2010 19:21:47 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 788441DB8015 for ; Fri, 16 Jul 2010 19:21:46 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 1FE041DB8014 for ; Fri, 16 Jul 2010 19:21:46 +0900 (JST) Date: Fri, 16 Jul 2010 19:17:05 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized Message-Id: <20100716191705.ee8cede6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100716191256.736C.A69D9226@jp.fujitsu.com> References: <20100716191006.7369.A69D9226@jp.fujitsu.com> <20100716191256.736C.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Mel Gorman , Nishimura Daisuke List-ID: On Fri, 16 Jul 2010 19:13:31 +0900 (JST) KOSAKI Motohiro wrote: > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > It mean shrink_zone() only scan 32 pages and immediately return even if > it doesn't reclaim any pages. > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro Acked-by: KAMEZAWA Hiroyuki > --- > mm/vmscan.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1691ad0..bd1d035 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > struct zone *zone, int nid) > { > struct scan_control sc = { > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > .may_writepage = !laptop_mode, > .may_unmap = 1, > .may_swap = !noswap, > -- > 1.6.5.2 > > > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org