linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
	Rik van Riel <riel@redhat.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [PATCH] vmscan: stop meaningless loop iteration when no reclaimable slab
Date: Fri,  9 Jul 2010 19:13:58 +0900 (JST)	[thread overview]
Message-ID: <20100709191308.FA25.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100709171850.FA22.A69D9226@jp.fujitsu.com>

If number of reclaimable slabs are zero, shrink_icache_memory() and
shrink_dcache_memory() return 0. but strangely shrink_slab() ignore
it and continue meaningless loop iteration.

This patch fixes it.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 mm/vmscan.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0f9f624..8f61adb 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -243,6 +243,11 @@ unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
 			int nr_before;
 
 			nr_before = (*shrinker->shrink)(0, gfp_mask);
+			/* no slab objects, no more reclaim. */
+			if (nr_before == 0) {
+				total_scan = 0;
+				break;
+			}
 			shrink_ret = (*shrinker->shrink)(this_scan, gfp_mask);
 			if (shrink_ret == -1)
 				break;
-- 
1.6.5.2



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-07-09 10:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  7:38 [PATCH v2 1/2] vmscan: don't subtraction of unsined KOSAKI Motohiro
2010-07-08  7:40 ` [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order KOSAKI Motohiro
2010-07-08 13:23   ` Rik van Riel
2010-07-08 14:04   ` Christoph Lameter
2010-07-08 20:31     ` Andrew Morton
2010-07-08 21:01       ` Christoph Lameter
2010-07-09  0:46         ` KOSAKI Motohiro
2010-07-09  8:21       ` KOSAKI Motohiro
2010-07-09 10:13         ` KOSAKI Motohiro [this message]
2010-07-09 10:53           ` [PATCH] vmscan: stop meaningless loop iteration when no reclaimable slab Minchan Kim
2010-07-09 11:04             ` KOSAKI Motohiro
2010-07-11 22:28               ` Minchan Kim
2010-07-13  4:48                 ` KOSAKI Motohiro
2010-07-13  6:33                   ` Minchan Kim
2010-07-09 14:02           ` Christoph Lameter
2010-07-13  4:59             ` KOSAKI Motohiro
2010-07-09  8:36   ` [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order Minchan Kim
2010-07-09 13:54     ` Christoph Lameter
2010-07-13  5:41     ` KOSAKI Motohiro
2010-07-15 19:15       ` Andrew Morton
2010-07-16  1:39         ` KOSAKI Motohiro
2010-07-16  1:44           ` Minchan Kim
2010-07-08  7:41 ` [PATCH v2 1/2] vmscan: don't subtraction of unsined KOSAKI Motohiro
2010-07-08 14:01   ` Christoph Lameter
2010-07-08 20:00 ` Andrew Morton
2010-07-09  1:16   ` KOSAKI Motohiro
2010-07-09  1:46     ` Minchan Kim
2010-07-09 22:28     ` Andrew Morton
2010-07-13  9:32       ` KOSAKI Motohiro
2010-07-14  1:50         ` Christoph Lameter
2010-07-14  2:15           ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100709191308.FA25.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox