From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order
Date: Thu, 8 Jul 2010 16:40:47 +0900 (JST) [thread overview]
Message-ID: <20100708163934.CD37.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100708163401.CD34.A69D9226@jp.fujitsu.com>
Fix simple argument error. Usually 'order' is very small value than
lru_pages. then it can makes unnecessary icache dropping.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/vmscan.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 8715da1..60d813b 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2617,6 +2617,8 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
n = zone_page_state(zone, NR_SLAB_RECLAIMABLE);
if (n > zone->min_slab_pages) {
+ unsigned long lru_pages = zone_reclaimable_pages(zone);
+
/*
* shrink_slab() does not currently allow us to determine how
* many pages were freed in this zone. So we take the current
@@ -2627,7 +2629,7 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
* Note that shrink_slab will free memory on all zones and may
* take a long time.
*/
- while (shrink_slab(sc.nr_scanned, gfp_mask, order) &&
+ while (shrink_slab(sc.nr_scanned, gfp_mask, lru_pages) &&
(zone_page_state(zone, NR_SLAB_RECLAIMABLE) + nr_pages > n))
;
--
1.6.5.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-08 7:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 7:38 [PATCH v2 1/2] vmscan: don't subtraction of unsined KOSAKI Motohiro
2010-07-08 7:40 ` KOSAKI Motohiro [this message]
2010-07-08 13:23 ` [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order Rik van Riel
2010-07-08 14:04 ` Christoph Lameter
2010-07-08 20:31 ` Andrew Morton
2010-07-08 21:01 ` Christoph Lameter
2010-07-09 0:46 ` KOSAKI Motohiro
2010-07-09 8:21 ` KOSAKI Motohiro
2010-07-09 10:13 ` [PATCH] vmscan: stop meaningless loop iteration when no reclaimable slab KOSAKI Motohiro
2010-07-09 10:53 ` Minchan Kim
2010-07-09 11:04 ` KOSAKI Motohiro
2010-07-11 22:28 ` Minchan Kim
2010-07-13 4:48 ` KOSAKI Motohiro
2010-07-13 6:33 ` Minchan Kim
2010-07-09 14:02 ` Christoph Lameter
2010-07-13 4:59 ` KOSAKI Motohiro
2010-07-09 8:36 ` [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order Minchan Kim
2010-07-09 13:54 ` Christoph Lameter
2010-07-13 5:41 ` KOSAKI Motohiro
2010-07-15 19:15 ` Andrew Morton
2010-07-16 1:39 ` KOSAKI Motohiro
2010-07-16 1:44 ` Minchan Kim
2010-07-08 7:41 ` [PATCH v2 1/2] vmscan: don't subtraction of unsined KOSAKI Motohiro
2010-07-08 14:01 ` Christoph Lameter
2010-07-08 20:00 ` Andrew Morton
2010-07-09 1:16 ` KOSAKI Motohiro
2010-07-09 1:46 ` Minchan Kim
2010-07-09 22:28 ` Andrew Morton
2010-07-13 9:32 ` KOSAKI Motohiro
2010-07-14 1:50 ` Christoph Lameter
2010-07-14 2:15 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708163934.CD37.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox