From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 001896B01B5 for ; Mon, 5 Jul 2010 04:49:52 -0400 (EDT) Date: Mon, 5 Jul 2010 17:44:37 +0900 From: Naoya Horiguchi Subject: Re: [PATCH 1/7] hugetlb: add missing unlock in avoidcopy path in hugetlb_cow() Message-ID: <20100705084437.GB29648@spritzera.linux.bs1.fc.nec.co.jp> References: <1278049646-29769-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1278049646-29769-2-git-send-email-n-horiguchi@ah.jp.nec.com> <20100702083143.GC12221@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <20100702083143.GC12221@basil.fritz.box> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Andrew Morton , Mel Gorman , Wu Fengguang , Jun'ichi Nomura , linux-mm , LKML List-ID: On Fri, Jul 02, 2010 at 10:31:43AM +0200, Andi Kleen wrote: > On Fri, Jul 02, 2010 at 02:47:20PM +0900, Naoya Horiguchi wrote: > > This patch fixes possible deadlock in hugepage lock_page() > > by adding missing unlock_page(). > > > > libhugetlbfs test will hit this bug when the next patch in this > > patchset ("hugetlb, HWPOISON: move PG_HWPoison bit check") is applied. > > This looks like a general bug fix that should be merged ASAP? > > Or do you think this cannot be hit at all without the other patches? This bug was introduced by patch "hugetlb, rmap: add reverse mapping for hugepage" in previous patchset (currently in linux-next) and it's not merged in mainline yet. So it's OK if this patch goes into linux-next by its merge to mainline. Thanks, Naoya Horiguchi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org