From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [PATCH 04/11] oom: oom_kill_process() need to check p is unkillable
Date: Wed, 30 Jun 2010 18:29:22 +0900 (JST) [thread overview]
Message-ID: <20100630182838.AA53.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100630172430.AA42.A69D9226@jp.fujitsu.com>
When oom_kill_allocating_task is enabled, an argument task of
oom_kill_process is not selected by select_bad_process(), It's
just out_of_memory() caller task. It mean the task can be
unkillable. check it first.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/oom_kill.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index a4a5439..ee00817 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -687,7 +687,8 @@ void out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
check_panic_on_oom(constraint, gfp_mask, order);
read_lock(&tasklist_lock);
- if (sysctl_oom_kill_allocating_task) {
+ if (sysctl_oom_kill_allocating_task &&
+ !oom_unkillable_task(current, NULL, nodemask)) {
/*
* oom_kill_process() needs tasklist_lock held. If it returns
* non-zero, current could not be killed so we must fallback to
--
1.6.5.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-30 9:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 9:25 [mmotm 0611][PATCH 00/11] various OOM bugfixes v3 KOSAKI Motohiro
2010-06-30 9:27 ` [PATCH 01/11] oom: don't try to kill oom_unkillable child KOSAKI Motohiro
2010-06-30 9:27 ` [PATCH 02/11] oom: oom_kill_process() doesn't select kthread child KOSAKI Motohiro
2010-06-30 13:55 ` Minchan Kim
2010-07-01 0:07 ` KOSAKI Motohiro
2010-07-01 13:38 ` Minchan Kim
2010-06-30 9:28 ` [PATCH 03/11] oom: make oom_unkillable_task() helper function KOSAKI Motohiro
2010-06-30 14:19 ` Minchan Kim
2010-07-01 0:07 ` KOSAKI Motohiro
2010-06-30 9:29 ` KOSAKI Motohiro [this message]
2010-06-30 13:57 ` [PATCH 04/11] oom: oom_kill_process() need to check p is unkillable Minchan Kim
2010-06-30 9:30 ` [PATCH 05/11] oom: /proc/<pid>/oom_score treat kernel thread honestly KOSAKI Motohiro
2010-06-30 14:03 ` Minchan Kim
2010-07-01 0:07 ` KOSAKI Motohiro
2010-07-01 14:36 ` Minchan Kim
2010-06-30 9:31 ` [PATCH 06/11] oom: kill duplicate OOM_DISABLE check KOSAKI Motohiro
2010-06-30 14:10 ` Minchan Kim
2010-06-30 9:31 ` [PATCH 07/11] oom: move OOM_DISABLE check from oom_kill_task to out_of_memory() KOSAKI Motohiro
2010-06-30 14:20 ` Minchan Kim
2010-07-01 0:07 ` KOSAKI Motohiro
2010-06-30 9:32 ` [PATCH 08/11] oom: cleanup has_intersects_mems_allowed() KOSAKI Motohiro
2010-06-30 9:32 ` [PATCH 09/11] oom: remove child->mm check from oom_kill_process() KOSAKI Motohiro
2010-06-30 14:30 ` Minchan Kim
2010-06-30 9:33 ` [PATCH 10/11] oom: give the dying task a higher priority KOSAKI Motohiro
2010-06-30 9:35 ` KOSAKI Motohiro
2010-06-30 14:40 ` Minchan Kim
2010-07-02 21:49 ` Andrew Morton
2010-07-06 0:49 ` KOSAKI Motohiro
2010-07-06 0:50 ` [PATCH 1/2] security: add const to security_task_setscheduler() KOSAKI Motohiro
2010-07-06 0:51 ` [PATCH 2/2] sched: make sched_param arugment static variables in some sched_setscheduler() caller KOSAKI Motohiro
2010-07-06 22:13 ` Steven Rostedt
2010-07-06 23:12 ` Andrew Morton
2010-07-06 23:49 ` Steven Rostedt
2010-07-07 0:02 ` Andrew Morton
2010-07-07 19:43 ` Peter Zijlstra
2010-06-30 9:34 ` [PATCH 11/11] oom: multi threaded process coredump don't make deadlock KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630182838.AA53.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox