From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id D28C66B0212 for ; Tue, 22 Jun 2010 10:39:24 -0400 (EDT) Date: Tue, 22 Jun 2010 16:38:56 +0200 From: Jan Kara Subject: Re: [PATCH RFC] mm: Implement balance_dirty_pages() through waiting for flusher thread Message-ID: <20100622143856.GG3338@quack.suse.cz> References: <1276797878-28893-1-git-send-email-jack@suse.cz> <20100618060901.GA6590@dastard> <20100621233628.GL3828@quack.suse.cz> <20100622054409.GP7869@dastard> <20100621231416.904c50c7.akpm@linux-foundation.org> <20100622100924.GQ7869@dastard> <20100622131745.GB3338@quack.suse.cz> <20100622135234.GA11561@localhost> <20100622143124.GA15235@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100622143124.GA15235@infradead.org> Sender: owner-linux-mm@kvack.org To: Christoph Hellwig Cc: Wu Fengguang , Jan Kara , Dave Chinner , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org List-ID: On Tue 22-06-10 10:31:24, Christoph Hellwig wrote: > On Tue, Jun 22, 2010 at 09:52:34PM +0800, Wu Fengguang wrote: > > 2) most writeback will be submitted by one per-bdi-flusher, so no worry > > of cache bouncing (this also means the per CPU counter error is > > normally bounded by the batch size) > > What counter are we talking about exactly? Once balanance_dirty_pages The new per-bdi counter I'd like to introduce. > stops submitting I/O the per-bdi flusher thread will in fact be > the only thing submitting writeback, unless you count direct invocations > of writeback_single_inode. Yes, I agree that the per-bdi flusher thread should be the only thread submitting lots of IO (there is direct reclaim or kswapd if we change direct reclaim but those should be negligible). So does this mean that also I/O completions will be local to the CPU running per-bdi flusher thread? Because the counter is incremented from the I/O completion callback. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org