From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 9/9] oom: give the dying task a higher priority
Date: Thu, 17 Jun 2010 10:51:35 +0900 (JST) [thread overview]
Message-ID: <20100617084811.FB42.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100616153120.GH9278@barrios-desktop>
> > + struct sched_param param = { .sched_priority = 1 };
> > +
> > + if (mem)
> > + return;
> > +
> > + if (rt_task(p)) {
> > + p->rt.time_slice = HZ;
> > + return;
>
> I have a question from long time ago.
> If we change rt.time_slice _without_ setscheduler, is it effective?
> I mean scheduler pick up the task faster than other normal task?
if p is SCHED_OTHER, no effective. if my understand is correct, that's
only meaningfull if p is SCHED_RR. that's the reason why I moved this
check into "if (rt_task())".
but honestly I haven't observed this works effectively. so, I agree
this can be removed as Luis mentioned.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-17 1:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 11:29 [PATCH 1/9] oom: don't try to kill oom_unkillable child KOSAKI Motohiro
2010-06-16 11:31 ` [PATCH 2/9] oom: rename badness() to oom_badness() KOSAKI Motohiro
2010-06-16 14:46 ` Minchan Kim
2010-06-16 21:40 ` David Rientjes
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-16 11:32 ` [PATCH 3/9] oom: oom_kill_process() doesn't select kthread child KOSAKI Motohiro
2010-06-16 15:02 ` Minchan Kim
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-16 11:32 ` [PATCH 4/9] oom: oom_kill_process() need to check p is unkillable KOSAKI Motohiro
2010-06-16 15:07 ` Minchan Kim
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-16 11:33 ` [PATCH 5/9] oom: make oom_unkillable_task() helper function KOSAKI Motohiro
2010-06-16 15:10 ` Minchan Kim
2010-06-16 11:34 ` [PATCH 6/9] oom: use same_thread_group instead comparing ->mm KOSAKI Motohiro
2010-06-16 12:24 ` Oleg Nesterov
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-16 15:15 ` Minchan Kim
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-16 11:34 ` [PATCH 7/9] oom: unify CAP_SYS_RAWIO check into other superuser check KOSAKI Motohiro
2010-06-16 11:35 ` [PATCH 8/9] oom: cleanup has_intersects_mems_allowed() KOSAKI Motohiro
2010-06-16 15:22 ` Minchan Kim
2010-06-16 11:36 ` [PATCH 9/9] oom: give the dying task a higher priority KOSAKI Motohiro
2010-06-16 15:31 ` Minchan Kim
2010-06-16 19:54 ` Luis Claudio R. Goncalves
2010-06-17 1:51 ` KOSAKI Motohiro
2010-06-17 1:51 ` KOSAKI Motohiro [this message]
2010-06-16 14:41 ` [PATCH 1/9] oom: don't try to kill oom_unkillable child Minchan Kim
2010-06-17 1:51 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617084811.FB42.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox