linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/12] Avoid overflowing of stack during page reclaim V2
Date: Tue, 15 Jun 2010 09:08:33 +0900	[thread overview]
Message-ID: <20100615090833.12f69ae5.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <1276514273-27693-1-git-send-email-mel@csn.ul.ie>

On Mon, 14 Jun 2010 12:17:41 +0100
Mel Gorman <mel@csn.ul.ie> wrote:

> SysBench
> ========
>                 traceonly-v2r5  stackreduce-v2r5     nodirect-v2r5
>            1 11025.01 ( 0.00%) 10249.52 (-7.57%) 10430.57 (-5.70%)
>            2  3844.63 ( 0.00%)  4988.95 (22.94%)  4038.95 ( 4.81%)
>            3  3210.23 ( 0.00%)  2918.52 (-9.99%)  3113.38 (-3.11%)
>            4  1958.91 ( 0.00%)  1987.69 ( 1.45%)  1808.37 (-8.32%)
>            5  2864.92 ( 0.00%)  3126.13 ( 8.36%)  2355.70 (-21.62%)
>            6  4831.63 ( 0.00%)  3815.67 (-26.63%)  4164.09 (-16.03%)
>            7  3788.37 ( 0.00%)  3140.39 (-20.63%)  3471.36 (-9.13%)
>            8  2293.61 ( 0.00%)  1636.87 (-40.12%)  1754.25 (-30.75%)
> FTrace Reclaim Statistics
>                                      traceonly-v2r5  stackreduce-v2r5     nodirect-v2r5
> Direct reclaims                               9843      13398      51651 
> Direct reclaim pages scanned                871367    1008709    3080593 
> Direct reclaim write async I/O               24883      30699          0 
> Direct reclaim write sync I/O                    0          0          0 

Hmm, page-scan and reclaims jumps up but...


> User/Sys Time Running Test (seconds)        734.52    712.39     703.9
> Percentage Time Spent Direct Reclaim         0.00%     0.00%     0.00%
> Total Elapsed Time (seconds)               9710.02   9589.20   9334.45
> Percentage Time kswapd Awake                 0.06%     0.00%     0.00%
> 

Execution time is reduced. Does this shows removing "I/O noise" by direct
reclaim makes the system happy ? or writeback in direct reclaim give
us too much costs ?

It seems I'll have to consider about avoiding direct-reciam in memcg, later.

BTW, I think we'll have to add wait-for-pages-to-be-cleaned trick in
direct reclaim if we want to avoid too much scanning, later.


Thank you for interesting test.

Regards,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-06-15  0:13 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 11:17 Mel Gorman
2010-06-14 11:17 ` [PATCH 01/12] tracing, vmscan: Add trace events for kswapd wakeup, sleeping and direct reclaim Mel Gorman
2010-06-14 15:45   ` Rik van Riel
2010-06-14 21:01   ` Larry Woodman
2010-06-14 11:17 ` [PATCH 02/12] tracing, vmscan: Add trace events for LRU page isolation Mel Gorman
2010-06-14 16:47   ` Rik van Riel
2010-06-14 21:02   ` Larry Woodman
2010-06-14 11:17 ` [PATCH 03/12] tracing, vmscan: Add trace event when a page is written Mel Gorman
2010-06-14 16:48   ` Rik van Riel
2010-06-14 21:02   ` Larry Woodman
2010-06-14 11:17 ` [PATCH 04/12] tracing, vmscan: Add a postprocessing script for reclaim-related ftrace events Mel Gorman
2010-06-14 17:55   ` Rik van Riel
2010-06-14 21:03   ` Larry Woodman
2010-06-14 11:17 ` [PATCH 05/12] vmscan: kill prev_priority completely Mel Gorman
2010-06-14 18:04   ` Rik van Riel
2010-06-16 23:37   ` Andrew Morton
2010-06-16 23:45     ` Rik van Riel
2010-06-17  0:18       ` Andrew Morton
2010-06-17  0:34         ` Rik van Riel
2010-06-25  8:29     ` KOSAKI Motohiro
2010-06-28 10:35       ` Mel Gorman
2010-06-14 11:17 ` [PATCH 06/12] vmscan: simplify shrink_inactive_list() Mel Gorman
2010-06-14 18:06   ` Rik van Riel
2010-06-15 10:13     ` Mel Gorman
2010-06-14 11:17 ` [PATCH 07/12] vmscan: Remove unnecessary temporary vars in do_try_to_free_pages Mel Gorman
2010-06-14 18:14   ` Rik van Riel
2010-06-14 11:17 ` [PATCH 08/12] vmscan: Setup pagevec as late as possible in shrink_inactive_list() Mel Gorman
2010-06-14 18:59   ` Rik van Riel
2010-06-15 10:47   ` Christoph Hellwig
2010-06-15 15:56     ` Mel Gorman
2010-06-16 23:43   ` Andrew Morton
2010-06-17 10:30     ` Mel Gorman
2010-06-14 11:17 ` [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list() Mel Gorman
2010-06-14 19:24   ` Rik van Riel
2010-06-16 23:48   ` Andrew Morton
2010-06-17 10:46     ` Mel Gorman
2010-06-14 11:17 ` [PATCH 10/12] vmscan: Update isolated page counters outside of main path in shrink_inactive_list() Mel Gorman
2010-06-14 19:42   ` Rik van Riel
2010-06-14 11:17 ` [PATCH 11/12] vmscan: Write out dirty pages in batch Mel Gorman
2010-06-14 21:13   ` Rik van Riel
2010-06-15 10:18     ` Mel Gorman
2010-06-14 23:11   ` Dave Chinner
2010-06-14 23:21     ` Andrew Morton
2010-06-15  0:39       ` Dave Chinner
2010-06-15  1:16         ` Rik van Riel
2010-06-15  1:45           ` Andrew Morton
2010-06-15  4:08             ` Rik van Riel
2010-06-15  4:37               ` Andrew Morton
2010-06-15  5:12                 ` Nick Piggin
2010-06-15  5:43                   ` [patch] mm: vmscan fix mapping use after free Nick Piggin
2010-06-15 13:23                     ` Mel Gorman
2010-06-15 11:01           ` [PATCH 11/12] vmscan: Write out dirty pages in batch Christoph Hellwig
2010-06-15 13:32             ` Rik van Riel
2010-06-15  1:39         ` Andrew Morton
2010-06-15  3:20           ` Dave Chinner
2010-06-15  4:15             ` Andrew Morton
2010-06-15  6:36               ` Dave Chinner
2010-06-15 10:28                 ` Evgeniy Polyakov
2010-06-15 10:55                   ` Nick Piggin
2010-06-15 11:10                     ` Christoph Hellwig
2010-06-15 11:20                       ` Nick Piggin
2010-06-15 23:20                     ` Dave Chinner
2010-06-16  6:04                       ` Nick Piggin
2010-06-15 11:08                   ` Christoph Hellwig
2010-06-15 11:43               ` Mel Gorman
2010-06-15 13:07                 ` tytso
2010-06-15 15:44                 ` Mel Gorman
2010-06-15 10:57       ` Christoph Hellwig
2010-06-15 10:53   ` Christoph Hellwig
2010-06-15 11:11     ` Mel Gorman
2010-06-15 11:13     ` Nick Piggin
2010-06-14 11:17 ` [PATCH 12/12] vmscan: Do not writeback pages in direct reclaim Mel Gorman
2010-06-14 21:55   ` Rik van Riel
2010-06-15 11:45     ` Mel Gorman
2010-06-15 13:34       ` Rik van Riel
2010-06-15 13:37         ` Christoph Hellwig
2010-06-15 13:54           ` Mel Gorman
2010-06-16  0:30             ` KAMEZAWA Hiroyuki
2010-06-15 14:02           ` Rik van Riel
2010-06-15 13:59         ` Mel Gorman
2010-06-15 14:04           ` Rik van Riel
2010-06-15 14:16             ` Mel Gorman
2010-06-16  0:17               ` KAMEZAWA Hiroyuki
2010-06-16  0:29                 ` Rik van Riel
2010-06-16  0:39                   ` KAMEZAWA Hiroyuki
2010-06-16  0:53                     ` Rik van Riel
2010-06-16  1:40                       ` KAMEZAWA Hiroyuki
2010-06-16  2:20                         ` KAMEZAWA Hiroyuki
2010-06-16  5:11                           ` Christoph Hellwig
2010-06-16 10:51                             ` Jens Axboe
2010-06-16  5:07                     ` Christoph Hellwig
2010-06-16  5:06                 ` Christoph Hellwig
2010-06-17  0:25                   ` KAMEZAWA Hiroyuki
2010-06-17  6:16                     ` Christoph Hellwig
2010-06-17  6:23                       ` KAMEZAWA Hiroyuki
2010-06-14 15:10 ` [PATCH 0/12] Avoid overflowing of stack during page reclaim V2 Christoph Hellwig
2010-06-15 11:45   ` Mel Gorman
2010-06-15  0:08 ` KAMEZAWA Hiroyuki [this message]
2010-06-15 11:49   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100615090833.12f69ae5.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox