From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id A7A326B01AC for ; Wed, 2 Jun 2010 09:54:05 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o52Ds1sB006266 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Wed, 2 Jun 2010 22:54:02 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id A38E645DE51 for ; Wed, 2 Jun 2010 22:54:01 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 7811645DE4F for ; Wed, 2 Jun 2010 22:54:01 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 1BCC5E08002 for ; Wed, 2 Jun 2010 22:54:01 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id CDCE21DB803B for ; Wed, 2 Jun 2010 22:54:00 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 5/5] oom: dump_tasks() use find_lock_task_mm() too In-Reply-To: <20100601145033.2446.A69D9226@jp.fujitsu.com> References: <20100601144238.243A.A69D9226@jp.fujitsu.com> <20100601145033.2446.A69D9226@jp.fujitsu.com> Message-Id: <20100602215344.F51B.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Date: Wed, 2 Jun 2010 22:54:00 +0900 (JST) Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Oleg Nesterov , David Rientjes , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin List-ID: > dump_task() should have the same process iteration logic as > select_bad_process(). > > It is needed for protecting from task exiting race. > > > Signed-off-by: KOSAKI Motohiro sorry, this patch made one warning. incremental patch is here. Signed-off-by: KOSAKI Motohiro --- mm/oom_kill.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index b06f8d1..f33a1b8 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -334,8 +334,6 @@ static void dump_tasks(const struct mem_cgroup *mem) "name\n"); for_each_process(p) { - struct mm_struct *mm; - if (is_global_init(p) || (p->flags & PF_KTHREAD)) continue; if (mem && !task_in_mem_cgroup(p, mem)) -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org