From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id B4B876B01B1 for ; Thu, 20 May 2010 20:36:58 -0400 (EDT) Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o4L0atkA011238 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Fri, 21 May 2010 09:36:55 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 87C9745DE79 for ; Fri, 21 May 2010 09:36:54 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 5982745DE6E for ; Fri, 21 May 2010 09:36:54 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id E954A1DB8041 for ; Fri, 21 May 2010 09:36:53 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id EB81F1DB8037 for ; Fri, 21 May 2010 09:36:52 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first In-Reply-To: <20100520010032.GC4089@localhost> References: <20100519174327.9591.A69D9226@jp.fujitsu.com> <20100520010032.GC4089@localhost> Message-Id: <20100521093629.1E44.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Fri, 21 May 2010 09:36:50 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: kosaki.motohiro@jp.fujitsu.com, "Li, Shaohua" , Johannes Weiner , Rik van Riel , Minchan Kim , Hugh Dickins , LKML , linux-mm , Andrew Morton List-ID: > Reviewed-by: Wu Fengguang > > The preceding comment "they need to go on the active_anon lru below" > also needs update. > Thanks. incremental patch is here. --- include/linux/swap.h | 10 ---------- mm/filemap.c | 2 +- 2 files changed, 1 insertions(+), 11 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 18420a9..4bfd932 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -224,21 +224,11 @@ static inline void lru_cache_add_anon(struct page *page) __lru_cache_add(page, LRU_INACTIVE_ANON); } -static inline void lru_cache_add_active_anon(struct page *page) -{ - __lru_cache_add(page, LRU_ACTIVE_ANON); -} - static inline void lru_cache_add_file(struct page *page) { __lru_cache_add(page, LRU_INACTIVE_FILE); } -static inline void lru_cache_add_active_file(struct page *page) -{ - __lru_cache_add(page, LRU_ACTIVE_FILE); -} - /* LRU Isolation modes. */ #define ISOLATE_INACTIVE 0 /* Isolate inactive pages. */ #define ISOLATE_ACTIVE 1 /* Isolate active pages. */ diff --git a/mm/filemap.c b/mm/filemap.c index 023ef61..a57931a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -441,7 +441,7 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping, /* * Splice_read and readahead add shmem/tmpfs pages into the page cache * before shmem_readpage has a chance to mark them as SwapBacked: they - * need to go on the active_anon lru below, and mem_cgroup_cache_charge + * need to go on the anon lru below, and mem_cgroup_cache_charge * (called in add_to_page_cache) needs to know where they're going too. */ if (mapping_cap_swap_backed(mapping)) -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org