From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mm@kvack.org, containers@lists.linux-foundation.org,
Andrew Morton <akpm@linux-foundation.org>,
Phil Carmody <ext-phil.2.carmody@nokia.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cgroups: make cftype.unregister_event() void-returning
Date: Mon, 10 May 2010 15:26:44 +0900 [thread overview]
Message-ID: <20100510152644.3ff6e0a5.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20100510150815.3d2f7647.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, 10 May 2010 15:08:15 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Sun, 9 May 2010 03:10:22 +0300
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
> > Since we unable to handle error returned by cftype.unregister_event()
> > properly, let's make the callback void-returning.
> >
> > mem_cgroup_unregister_event() has been rewritten to be "never fail"
> > function. On mem_cgroup_usage_register_event() we save old buffer
> > for thresholds array and reuse it in mem_cgroup_usage_unregister_event()
> > to avoid allocation.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>
> Hmm, just reusing buffer isn't enough ?
> as
> tmp = memory->thresholds;
> reduce entries on tmp
> And what happens when
>
> register
> register
> register
> unregister (use preallocated buffer)
> unregister ????
> unregister
>
Ah, sorry my eyes were wrong.
The fix seems to work.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-05-10 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 0:10 Kirill A. Shutemov
2010-05-10 6:08 ` KAMEZAWA Hiroyuki
2010-05-10 6:26 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510152644.3ff6e0a5.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=ext-phil.2.carmody@nokia.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox