From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id ECD146B01F0 for ; Tue, 20 Apr 2010 05:59:17 -0400 (EDT) Date: Tue, 20 Apr 2010 10:58:55 +0100 From: Mel Gorman Subject: Re: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded Message-ID: <20100420095855.GE19264@csn.ul.ie> References: <201004152210.o3FMA7KV001909@imap1.linux-foundation.org> <20100419190133.50a13021.kamezawa.hiroyu@jp.fujitsu.com> <20100419181442.GA19264@csn.ul.ie> <20100419193919.GB19264@csn.ul.ie> <20100420082057.GC19264@csn.ul.ie> <20100420084454.GD19264@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "linux-mm@kvack.org" , "kosaki.motohiro@jp.fujitsu.com" List-ID: On Tue, Apr 20, 2010 at 06:50:23PM +0900, Minchan Kim wrote: > On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman wrote: > > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote: > >> > >> Yes. Then, Let's add comment like split_page. :) > >> /* > >> * Note: this is probably too low level an operation for use in drivers. > >> * Please consult with lkml before using this in your driver. > >> */ > >> > > > > I can, but the comment that was there says it's like split_page except the > > page is already free. This also covers not using it in a driver. > > I see. In addition, you already mentioned "As this is only being used > for migration". > I missed one. > I don't have any against one. > Will you repost v2 which move split_free_pages out of compaction.c? I don't understand your suggestion. split_free_pages is already out of compaction.c. > Anyway, feel free to add my reviewed-by sign. > Thanks, Mel. > > Reviewed-by: Minchan Kim > Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org