From: Nick Piggin <npiggin@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, xfs@oss.sgi.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm: add context argument to shrinker callback
Date: Tue, 20 Apr 2010 00:00:39 +1000 [thread overview]
Message-ID: <20100419140039.GQ5683@laptop> (raw)
In-Reply-To: <20100418001514.GA26575@infradead.org>
On Sat, Apr 17, 2010 at 08:15:14PM -0400, Christoph Hellwig wrote:
> Any chance we can still get this into 2.6.34? It's really needed to fix
> a regression in XFS that would be hard to impossible to work around
> inside the fs. While it touches quite a few places the changes are
> trivial and well understood.
Why do you even need this context argument? Reclaim is not doing anything
smart about this, it would just call each call shrinker in turn.
Do you not have an easily traversable list of mountpoints? Can you just
make a list of them? It would be cheaper than putting a whole shrinker
structure into them anyway.
The main reason I would be against proliferation of dynamic shrinker
registration would be that it could change reclaim behaviour depending
on how they get ordered (in the cache the caches are semi-dependent,
like inode cache and dentry cache).
Unless there is a reason I missed, I would much prefer not to do this
like this.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-19 14:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 0:24 [PATCH 0/2] Context sensitive memory shrinker support Dave Chinner
2010-04-13 0:24 ` [PATCH 1/2] mm: add context argument to shrinker callback Dave Chinner
2010-04-13 8:17 ` KOSAKI Motohiro
2010-04-18 0:15 ` Christoph Hellwig
2010-04-19 14:00 ` Nick Piggin [this message]
2010-04-20 0:41 ` Dave Chinner
2010-04-20 8:38 ` Nick Piggin
2010-04-20 10:32 ` Dave Chinner
2010-04-21 8:40 ` Nick Piggin
2010-04-22 16:32 ` Christoph Hellwig
2010-04-22 16:38 ` Nick Piggin
2010-04-22 16:42 ` Christoph Hellwig
2010-04-22 16:57 ` Nick Piggin
2010-04-23 1:58 ` Dave Chinner
2010-04-28 3:38 ` Dave Chinner
2010-04-28 9:39 ` Avi Kivity
2010-04-28 13:45 ` Dave Chinner
2010-04-13 0:24 ` [PATCH 2/2] xfs: add a shrinker to background inode reclaim Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419140039.GQ5683@laptop \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox