From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id E8E026B01EF for ; Fri, 16 Apr 2010 19:03:42 -0400 (EDT) Date: Sat, 17 Apr 2010 01:03:32 +0200 From: Johannes Weiner Subject: Re: [PATCH 07/10] vmscan: Remove unnecessary temporary variables in shrink_zone() Message-ID: <20100416230332.GH20640@cmpxchg.org> References: <1271352103-2280-1-git-send-email-mel@csn.ul.ie> <1271352103-2280-8-git-send-email-mel@csn.ul.ie> <20100416115053.27A1.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100416115053.27A1.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Mel Gorman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Mason , Dave Chinner , Andi Kleen List-ID: On Fri, Apr 16, 2010 at 11:51:26AM +0900, KOSAKI Motohiro wrote: > > Two variables are declared that are unnecessary in shrink_zone() as they > > already exist int the scan_control. Remove them > > > > Signed-off-by: Mel Gorman > > ok. > Reviewed-by: KOSAKI Motohiro You confuse me, you added the local variables yourself in 01dbe5c9 for performance reasons. Doesn't that still hold? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org