From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id A7E1E6B01F2 for ; Tue, 13 Apr 2010 12:14:56 -0400 (EDT) Date: Tue, 13 Apr 2010 17:14:22 +0100 From: Mel Gorman Subject: Re: [PATCH 3/6] change alloc function in alloc_slab_page Message-ID: <20100413161421.GH25756@csn.ul.ie> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <8b348d9cc1ea4960488b193b7e8378876918c0d4.1271171877.git.minchan.kim@gmail.com> <20100413155253.GD25756@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter List-ID: On Wed, Apr 14, 2010 at 01:01:31AM +0900, Minchan Kim wrote: > On Wed, Apr 14, 2010 at 12:52 AM, Mel Gorman wrote: > > On Wed, Apr 14, 2010 at 12:25:00AM +0900, Minchan Kim wrote: > >> alloc_slab_page never calls alloc_pages_node with -1. > > > > Are you certain? What about > > > > __kmalloc > > -> slab_alloc (passed -1 as a node from __kmalloc) > > -> __slab_alloc > > -> new_slab > > -> allocate_slab > > -> alloc_slab_page > > > > Sorry for writing confusing changelog. > > I means if node == -1 alloc_slab_page always calls alloc_pages. > So we don't need redundant check. > When the changelog is fixed up, feel free to add; Reviewed-by: Mel Gorman -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org