From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
Shaohua Li <shaohua.li@intel.com>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Tue, 13 Apr 2010 10:30:34 +0900 (JST) [thread overview]
Message-ID: <20100413102641.4A18.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <4BBF9B34.5040909@redhat.com>
> On 04/09/2010 05:20 PM, Andrew Morton wrote:
>
> > Come to that, it's not obvious that we need this in 2.6.34 either. What
> > is the user-visible impact here?
>
> I suspect very little impact, especially during workloads
> where we can just reclaim clean page cache at DEF_PRIORITY.
> FWIW, the patch looks good to me, so:
>
> Acked-by: Rik van Riel <riel@redhat.com>
>
I'm surprised this ack a bit. Rik, do you have any improvement plan about
streaming io detection logic?
I think the patch have a slightly marginal benefit, it help to <1% scan
ratio case. but it have big regression, it cause streaming io (e.g. backup
operation) makes tons swap.
So, I thought we sould do either,
1) drop this one
2) merge to change stream io detection logic improvement at first, and
merge this one at second.
Am i missing something?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-13 1:30 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 5:53 Shaohua Li
2010-03-30 6:08 ` KOSAKI Motohiro
2010-03-30 6:32 ` Shaohua Li
2010-03-30 6:40 ` KOSAKI Motohiro
2010-03-30 6:53 ` Shaohua Li
2010-03-30 7:31 ` KOSAKI Motohiro
2010-03-30 8:13 ` Shaohua Li
2010-03-31 4:53 ` Shaohua Li
2010-03-31 5:38 ` KOSAKI Motohiro
2010-03-31 5:51 ` Wu Fengguang
2010-03-31 6:00 ` KOSAKI Motohiro
2010-03-31 6:03 ` Wu Fengguang
2010-04-01 22:16 ` Andrew Morton
2010-04-02 9:13 ` KOSAKI Motohiro
2010-04-06 1:22 ` Wu Fengguang
2010-04-06 3:36 ` Rik van Riel
2010-03-31 5:53 ` KOSAKI Motohiro
2010-04-02 6:50 ` Shaohua Li
2010-04-02 9:14 ` KOSAKI Motohiro
2010-04-02 9:24 ` Shaohua Li
2010-04-04 14:19 ` KOSAKI Motohiro
2010-04-06 1:25 ` Shaohua Li
2010-04-06 1:36 ` KOSAKI Motohiro
2010-04-06 1:50 ` Wu Fengguang
2010-04-06 2:06 ` KOSAKI Motohiro
2010-04-06 2:30 ` Wu Fengguang
2010-04-06 2:58 ` KOSAKI Motohiro
2010-04-06 3:31 ` Wu Fengguang
2010-04-06 3:40 ` Rik van Riel
2010-04-06 4:49 ` Wu Fengguang
2010-04-06 5:09 ` Shaohua Li
2010-04-04 0:48 ` Wu Fengguang
2010-04-06 1:27 ` Shaohua Li
2010-04-06 5:03 ` Wu Fengguang
2010-04-06 5:36 ` Shaohua Li
2010-04-09 6:51 ` Shaohua Li
2010-04-09 21:20 ` Andrew Morton
2010-04-09 21:25 ` Rik van Riel
2010-04-13 1:30 ` KOSAKI Motohiro [this message]
2010-04-13 2:42 ` Rik van Riel
2010-04-13 7:55 ` KOSAKI Motohiro
2010-04-13 8:55 ` KOSAKI Motohiro
2010-04-14 1:27 ` Shaohua Li
2010-04-15 3:25 ` KOSAKI Motohiro
2010-04-12 1:57 ` Shaohua Li
2010-03-31 5:41 ` Wu Fengguang
2010-03-30 10:17 ` Minchan Kim
2010-03-30 10:25 ` KOSAKI Motohiro
2010-03-30 11:56 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413102641.4A18.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox