From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"menage@google.com" <menage@google.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
stable@kernel.org
Subject: Re: [PATCH] fix cgroup procs documentation
Date: Fri, 9 Apr 2010 12:20:01 +0900 [thread overview]
Message-ID: <20100409122001.60967001.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <4BBE9D58.2010602@cn.fujitsu.com>
On Fri, 09 Apr 2010 11:22:00 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
> > If people believe this information, they'll usr cgroup.procs file and will
> > see cgroup doesn'w work as expected.
> > The patch itself is against -mm.
> >
> > ==
> > Writing to cgroup.procs is not supported now.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > ---
> > Documentation/cgroups/cgroups.txt | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> > ===================================================================
> > --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> > +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> > @@ -235,8 +235,7 @@ containing the following files describin
> > - cgroup.procs: list of tgids in the cgroup. This list is not
> > guaranteed to be sorted or free of duplicate tgids, and userspace
> > should sort/uniquify the list if this property is required.
> > - Writing a tgid into this file moves all threads with that tgid into
> > - this cgroup.
> > + This is a read-only file, now.
>
> I think the better wording is "for now". :)
>
ok. BTW, does anyone work on this ?
==
Writing to cgroup.procs is not supported now.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
Documentation/cgroups/cgroups.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: mmotm-temp/Documentation/cgroups/cgroups.txt
===================================================================
--- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
+++ mmotm-temp/Documentation/cgroups/cgroups.txt
@@ -235,8 +235,7 @@ containing the following files describin
- cgroup.procs: list of tgids in the cgroup. This list is not
guaranteed to be sorted or free of duplicate tgids, and userspace
should sort/uniquify the list if this property is required.
- Writing a tgid into this file moves all threads with that tgid into
- this cgroup.
+ This is a read-only file, for now.
- notify_on_release flag: run the release agent on exit?
- release_agent: the path to use for release notifications (this file
exists in the top cgroup only)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-09 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 3:11 KAMEZAWA Hiroyuki
2010-04-09 3:22 ` Li Zefan
2010-04-09 3:20 ` KAMEZAWA Hiroyuki [this message]
2010-04-09 3:31 ` Li Zefan
2010-04-09 3:48 ` Ben Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100409122001.60967001.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox