From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, andi.kleen@intel.com,
fengguang.wu@intel.com
Subject: Re: [PATCH 2/2] [BUGFIX] pagemap: fix pfn calculation for hugepage
Date: Wed, 24 Mar 2010 14:22:50 +0900 [thread overview]
Message-ID: <20100324142250.62753e03.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20100324051845.GA9017@spritzerA.linux.bs1.fc.nec.co.jp>
On Wed, 24 Mar 2010 14:18:45 +0900
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> On Fri, Mar 19, 2010 at 05:13:10PM +0900, KAMEZAWA Hiroyuki wrote:
> ...
> > >
> > > But, this means hugeltb_entry() is not called per hugetlb entry...isn't it ?
> > >
> > > Why hugetlb_entry() cannot be called per hugeltb entry ? Don't we need a code
> > > for a case as pmd_size != hugetlb_size in walk_page_range() for generic fix ?
> > >
> >
> > How about this style ? This is an idea-level patch. not tested at all.
> > (I have no test enviroment for multiple hugepage size.)
> >
> > feel free to reuse fragments from this patch.
> >
>
> So the point is calling hugetlb_entry() for each huge page, right?
>
yes.
> It looks good.
> I've rewritten my patch based on your idea and make sure it works.
> Is it ok to add your Signed-off-by?
Of course.
Thanks.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-24 5:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 6:26 Naoya Horiguchi
2010-03-19 7:10 ` KAMEZAWA Hiroyuki
2010-03-19 7:27 ` KAMEZAWA Hiroyuki
2010-03-19 8:13 ` KAMEZAWA Hiroyuki
2010-03-24 5:18 ` Naoya Horiguchi
2010-03-24 5:22 ` KAMEZAWA Hiroyuki [this message]
2010-03-19 8:40 ` Naoya Horiguchi
2010-03-19 8:37 ` Naoya Horiguchi
2010-03-19 8:48 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324142250.62753e03.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox