From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, andi.kleen@intel.com,
fengguang.wu@intel.com
Subject: Re: [PATCH 1/2] pagemap: add #ifdefs CONFIG_HUGETLB_PAGE on code walking hugetlb vma
Date: Fri, 19 Mar 2010 16:15:04 +0900 [thread overview]
Message-ID: <20100319161504.2c5c65b5.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20100319065334.GB12389@spritzerA.linux.bs1.fc.nec.co.jp>
On Fri, 19 Mar 2010 15:53:34 +0900
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> On Fri, Mar 19, 2010 at 03:29:34PM +0900, KAMEZAWA Hiroyuki wrote:
> > On Fri, 19 Mar 2010 15:26:35 +0900
> > Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> >
> > > If !CONFIG_HUGETLB_PAGE, pagemap_hugetlb_range() is never called.
> > > So put it (and its calling function) into #ifdef block.
> > >
> > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> >
> > Hmm? What is benefit ? Is this broken now ?
> >
>
> Not broken, but this is needed to avoid build error with patch 2/2 applied,
> where I move huge_pte_offset() (not defined when !HUGETLB_PAGE)
> into pagemap_hugetlb_range().
>
I think this should be merged with 2/2....if necessary.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-19 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 6:26 Naoya Horiguchi
2010-03-19 6:29 ` KAMEZAWA Hiroyuki
2010-03-19 6:53 ` Naoya Horiguchi
2010-03-19 7:15 ` KAMEZAWA Hiroyuki [this message]
2010-03-19 8:30 ` Naoya Horiguchi
2010-03-19 20:07 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319161504.2c5c65b5.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox