From: Andrea Righi <arighi@develer.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vivek Goyal <vgoyal@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Suleiman Souhlal <suleiman@google.com>,
Greg Thelen <gthelen@google.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -mmotm 1/5] memcg: disable irq at page cgroup lock
Date: Mon, 15 Mar 2010 11:00:25 +0100 [thread overview]
Message-ID: <20100315100024.GA1653@linux.develer.com> (raw)
In-Reply-To: <20100315090638.ee416d93.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, Mar 15, 2010 at 09:06:38AM +0900, KAMEZAWA Hiroyuki wrote:
> On Mon, 15 Mar 2010 00:26:38 +0100
> Andrea Righi <arighi@develer.com> wrote:
>
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > Now, file-mapped is maintaiend. But more generic update function
> > will be needed for dirty page accounting.
> >
> > For accountig page status, we have to guarantee lock_page_cgroup()
> > will be never called under tree_lock held.
> > To guarantee that, we use trylock at updating status.
> > By this, we do fuzzy accounting, but in almost all case, it's correct.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Bad patch title...."use trylock for safe accounting in some contexts" ?
OK, sounds better. I just copy & paste the email subject, but the title
was probably related to the old lock_page_cgroup()+irq_disable patch.
Thanks,
-Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-15 10:00 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 23:26 [PATCH -mmotm 0/5] memcg: per cgroup dirty limit (v7) Andrea Righi
2010-03-14 23:26 ` [PATCH -mmotm 1/5] memcg: disable irq at page cgroup lock Andrea Righi
2010-03-15 0:06 ` KAMEZAWA Hiroyuki
2010-03-15 10:00 ` Andrea Righi [this message]
2010-03-17 7:04 ` Balbir Singh
2010-03-17 11:58 ` Balbir Singh
2010-03-17 23:54 ` KAMEZAWA Hiroyuki
2010-03-18 0:45 ` KAMEZAWA Hiroyuki
2010-03-18 2:16 ` Daisuke Nishimura
2010-03-18 2:58 ` KAMEZAWA Hiroyuki
2010-03-18 5:12 ` Balbir Singh
2010-03-18 4:19 ` Balbir Singh
2010-03-18 4:21 ` KAMEZAWA Hiroyuki
2010-03-18 6:25 ` Balbir Singh
2010-03-18 4:35 ` KAMEZAWA Hiroyuki
2010-03-18 16:28 ` Balbir Singh
2010-03-19 1:23 ` KAMEZAWA Hiroyuki
2010-03-19 2:40 ` Balbir Singh
2010-03-19 3:00 ` KAMEZAWA Hiroyuki
[not found] ` <xr93hbnepmj6.fsf@ninji.mtv.corp.google.com>
2010-04-14 6:55 ` Greg Thelen
2010-04-14 9:29 ` KAMEZAWA Hiroyuki
2010-04-14 14:04 ` Vivek Goyal
2010-04-14 19:31 ` Greg Thelen
2010-04-15 0:14 ` KAMEZAWA Hiroyuki
2010-04-14 16:22 ` Greg Thelen
2010-04-15 0:22 ` KAMEZAWA Hiroyuki
2010-04-14 14:05 ` Vivek Goyal
2010-04-14 20:14 ` Greg Thelen
2010-04-15 2:40 ` Daisuke Nishimura
2010-04-15 4:48 ` Greg Thelen
2010-04-15 6:21 ` Daisuke Nishimura
2010-04-15 6:38 ` Greg Thelen
2010-04-15 6:54 ` KAMEZAWA Hiroyuki
2010-04-23 20:17 ` Greg Thelen
2010-04-23 20:54 ` Peter Zijlstra
2010-04-24 15:53 ` Greg Thelen
2010-04-23 20:57 ` Peter Zijlstra
2010-04-24 2:22 ` KAMEZAWA Hiroyuki
2010-04-23 21:19 ` Peter Zijlstra
2010-04-24 2:19 ` KAMEZAWA Hiroyuki
2010-04-14 14:44 ` Balbir Singh
2010-03-14 23:26 ` [PATCH -mmotm 2/5] memcg: dirty memory documentation Andrea Righi
2010-03-16 7:41 ` Daisuke Nishimura
2010-03-17 17:48 ` Greg Thelen
2010-03-17 19:02 ` Balbir Singh
2010-03-17 22:43 ` Andrea Righi
2010-03-14 23:26 ` [PATCH -mmotm 3/5] page_cgroup: introduce file cache flags Andrea Righi
2010-03-14 23:26 ` [PATCH -mmotm 4/5] memcg: dirty pages accounting and limiting infrastructure Andrea Righi
2010-03-15 2:26 ` KAMEZAWA Hiroyuki
2010-03-16 2:32 ` Daisuke Nishimura
2010-03-16 14:11 ` Vivek Goyal
2010-03-16 15:09 ` Daisuke Nishimura
2010-03-17 22:37 ` Andrea Righi
2010-03-17 22:52 ` Andrea Righi
2010-03-18 6:48 ` Greg Thelen
2010-03-14 23:26 ` [PATCH -mmotm 5/5] memcg: dirty pages instrumentation Andrea Righi
2010-03-15 2:31 ` KAMEZAWA Hiroyuki
2010-03-15 2:36 ` [PATCH -mmotm 0/5] memcg: per cgroup dirty limit (v7) KAMEZAWA Hiroyuki
2010-03-15 10:02 ` Andrea Righi
2010-03-15 17:12 ` Vivek Goyal
2010-03-15 17:19 ` Vivek Goyal
2010-03-17 11:54 ` Balbir Singh
2010-03-17 13:34 ` Vivek Goyal
2010-03-17 18:53 ` Balbir Singh
2010-03-17 19:15 ` Vivek Goyal
2010-03-17 19:17 ` Balbir Singh
2010-03-17 19:48 ` Vivek Goyal
2010-03-17 6:44 ` Balbir Singh
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 23:00 [PATCH -mmotm 0/5] memcg: per cgroup dirty limit (v6) Andrea Righi
2010-03-09 23:00 ` [PATCH -mmotm 1/5] memcg: disable irq at page cgroup lock Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315100024.GA1653@linux.develer.com \
--to=arighi@develer.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=peterz@infradead.org \
--cc=suleiman@google.com \
--cc=trond.myklebust@fys.uio.no \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox