Re: [RFC][PATCH 1/3] memcg: wake up filter in oom waitqueue

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Fri, 12 Mar 2010 11:54:29 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> On Fri, 12 Mar 2010 11:38:38 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > On Fri, 12 Mar 2010 11:30:28 +0900
> > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > 
> > > On Thu, 11 Mar 2010 16:55:59 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > > > +	/* check hierarchy */
> > > > +	if (!css_is_ancestor(&oom_wait_info->mem->css, &wake_mem->css) &&
> > > > +	    !css_is_ancestor(&wake_mem->css, &oom_wait_info->mem->css))
> > > > +		return 0;
> > > > +
> > > I think these conditions are wrong.
> > > This can wake up tasks in oom_wait_info->mem when:
> > > 
> > >   00/ <- wake_mem: use_hierarchy == false
> > >     aa/ <- oom_wait_info->mem: use_hierarchy == true;
> > > 
> > Hmm. I think this line bails out above case.
> > 
> > > +	if (!oom_wait_info->mem->use_hierarchy || !wake_mem->use_hierarchy)
> > > +		return 0;
> > 
> > No ?
> > 
> Oops! you're right. I misunderstood the code.
> 
> Then, this patch looks good to me.
> 
> 	Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> 

Thank you very much!

-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>