From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 08A466B0047 for ; Thu, 25 Feb 2010 15:04:17 -0500 (EST) From: "Rafael J. Wysocki" Subject: Re: s2disk hang update Date: Thu, 25 Feb 2010 21:04:51 +0100 References: <9b2b86521001020703v23152d0cy3ba2c08df88c0a79@mail.gmail.com> <201002242152.55408.rjw@sisk.pl> <9b2b86521002250510m75c8b314o37388a04b53a2b67@mail.gmail.com> In-Reply-To: <9b2b86521002250510m75c8b314o37388a04b53a2b67@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002252104.51187.rjw@sisk.pl> Sender: owner-linux-mm@kvack.org To: Alan Jenkins Cc: Mel Gorman , hugh.dickins@tiscali.co.uk, Pavel Machek , pm list , linux-kernel , Kernel Testers List , KAMEZAWA Hiroyuki , Linux MM List-ID: On Thursday 25 February 2010, Alan Jenkins wrote: > On 2/24/10, Rafael J. Wysocki wrote: > > On Wednesday 24 February 2010, Alan Jenkins wrote: ... > > > - while (to_free_normal > 0 && to_free_highmem > 0) { > > + while (to_free_normal > 0 || to_free_highmem > 0) { > > Yes, that seems to do it. No more hangs so far (and I can still > reproduce the hang with too many applications if I un-apply the > patch). OK, great. Is this with or without the NOIO-enforcing patch? > I did see a non-fatal allocation failure though, so I'm still not sure > that the current implementation is strictly correct. > > This is without the patch to increase "to_free_normal". If I get the > allocation failure again, should I try testing the "free 20% extra" > patch? Either that or try to increase SPARE_PAGES. That should actually work with the last patch applied. :-) Rafael -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org