From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 269196B0078 for ; Tue, 16 Feb 2010 21:27:25 -0500 (EST) Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o1H2RPWp012166 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Wed, 17 Feb 2010 11:27:25 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 17DBE45DE6E for ; Wed, 17 Feb 2010 11:27:25 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id BE9DF45DE4D for ; Wed, 17 Feb 2010 11:27:24 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 256F31DB8043 for ; Wed, 17 Feb 2010 11:27:24 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 9A4D41DB8044 for ; Wed, 17 Feb 2010 11:27:23 +0900 (JST) Date: Wed, 17 Feb 2010 11:23:53 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom mode Message-Id: <20100217112353.b90f732a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100217111319.d342f10e.kamezawa.hiroyu@jp.fujitsu.com> References: <20100216090005.f362f869.kamezawa.hiroyu@jp.fujitsu.com> <20100216092311.86bceb0c.kamezawa.hiroyu@jp.fujitsu.com> <20100217084239.265c65ea.kamezawa.hiroyu@jp.fujitsu.com> <20100217090124.398769d5.kamezawa.hiroyu@jp.fujitsu.com> <20100217094137.a0d26fbb.kamezawa.hiroyu@jp.fujitsu.com> <20100217111319.d342f10e.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: David Rientjes , Andrew Morton , Rik van Riel , Nick Piggin , Andrea Arcangeli , Balbir Singh , Lubos Lunak , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, 17 Feb 2010 11:13:19 +0900 KAMEZAWA Hiroyuki wrote: > On Tue, 16 Feb 2010 17:58:05 -0800 (PST) > David Rientjes wrote: > > > On Tue, 16 Feb 2010, David Rientjes wrote: > > > > > Ok, I'll eliminate pagefault_out_of_memory() and get it to use > > > out_of_memory() by only checking for constrained_alloc() when > > > gfp_mask != 0. > > > > > > > What do you think about making pagefaults use out_of_memory() directly and > > respecting the sysctl_panic_on_oom settings? > > > > I don't think this patch is good. Because several memcg can > cause oom at the same time independently, system-wide oom locking is > unsuitable. And basically. memcg's oom means "the usage over the limits!!" and does never means "resouce is exhausted!!". Then, marking OOM to zones sounds strange. You can cause oom in 64MB memcg in 64GB system. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org