From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: [PATCH 0/2] memcg patches around event counting...softlimit and thresholds v2
Date: Fri, 12 Feb 2010 18:05:08 +0900 [thread overview]
Message-ID: <20100212180508.eb58a4d1.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20100212154422.58bfdc4d.kamezawa.hiroyu@jp.fujitsu.com>
Thank you for review. This is v2.
Thanks,
-Kame
On Fri, 12 Feb 2010 15:44:22 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> These 2 patches are updates for memcg's event counter.
>
> Memcg has 2 counters but they counts the same thing. Just usages are
> different from each other. This patch tries to combine them.
>
> Event counting is done per page but event check is done per charge.
> But, now, move_task at el. does charge() in batched manner. So, it's better
> to do event check per page (not per charge.)
>
> (*) There may be an opinion that threshold check should be done at charge().
> But, at charge(), event counter is not incremented, anyway.
> Then, some another idea is appreciated to check thresholds at charges.
> In other view, checking threshold at "precharge" can cause miss-fire of
> event notifier. So, checking threshold at commit has some sense, I think.
>
> I wonder I should add RFC..but this patch clears my concerns since memcg-threshold
> was merged. So, I didn't.
>
> Any comment is welcome. (I'm sorry if my reply is delayed.)
>
> Thanks,
> -Kame
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-12 9:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 6:44 [PATCH 0/2] memcg patches around event counting...softlimit and thresholds KAMEZAWA Hiroyuki
2010-02-12 6:47 ` [PATCH 1/2] memcg : update softlimit and threshold at commit KAMEZAWA Hiroyuki
2010-02-12 7:33 ` Daisuke Nishimura
2010-02-12 7:42 ` KAMEZAWA Hiroyuki
2010-02-12 6:48 ` [PATCH 2/2] memcg: share event counter rather than duplicate KAMEZAWA Hiroyuki
2010-02-12 7:40 ` Daisuke Nishimura
2010-02-12 7:41 ` KAMEZAWA Hiroyuki
2010-02-12 7:46 ` Kirill A. Shutemov
2010-02-12 7:46 ` KAMEZAWA Hiroyuki
2010-02-12 8:07 ` Kirill A. Shutemov
2010-02-12 8:19 ` KAMEZAWA Hiroyuki
2010-02-12 8:49 ` Kirill A. Shutemov
2010-02-12 8:51 ` KAMEZAWA Hiroyuki
2010-02-12 9:05 ` KAMEZAWA Hiroyuki [this message]
2010-02-12 9:06 ` [PATCH 1/2] memcg: update threshold and softlimit at commit v2 KAMEZAWA Hiroyuki
2010-02-12 9:09 ` [PATCH 2/2] memcg : share event counter rather than duplicate v2 KAMEZAWA Hiroyuki
2010-02-12 11:48 ` Daisuke Nishimura
2010-02-15 0:19 ` KAMEZAWA Hiroyuki
2010-03-09 23:15 ` Andrew Morton
2010-02-15 10:57 ` Kirill A. Shutemov
2010-02-16 0:16 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212180508.eb58a4d1.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox