From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id EEC396B0047 for ; Thu, 11 Feb 2010 21:33:10 -0500 (EST) Date: Fri, 12 Feb 2010 11:20:55 +0900 From: Daisuke Nishimura Subject: Re: [BUGFIX][PATCH] memcg: fix oom killing a child process in an other cgroup Message-Id: <20100212112055.47774d59.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20100212105318.caf37133.kamezawa.hiroyu@jp.fujitsu.com> References: <20100212105318.caf37133.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , stable@kernel.org, minchan.kim@gmail.com, rientjes@google.com, "balbir@linux.vnet.ibm.com" , Daisuke Nishimura List-ID: On Fri, 12 Feb 2010 10:53:18 +0900, KAMEZAWA Hiroyuki wrote: > This patch itself is againt mmotm-Feb10 but can be applied to 2.6.32.8 > without problem. > > == > From: KAMEZAWA Hiroyuki > > Now, oom-killer is memcg aware and it finds the worst process from > processes under memcg(s) in oom. Then, it kills victim's child at first. > It may kill a child in other cgroup and may not be any help for recovery. > And it will break the assumption users have... > > This patch fixes it. > This bug should definitely be fixed. Thank you for finding and fixing it. Reviewed-by: Daisuke Nishimura > CC: stable@kernel.org > CC: Minchan Kim > CC: Balbir Singh > CC: Daisuke Nishimura > Acked-by: David Rientjes > Signed-off-by: KAMEZAWA Hiroyuki > > --- > mm/oom_kill.c | 2 ++ > 1 file changed, 2 insertions(+) > > Index: mmotm-2.6.33-Feb10/mm/oom_kill.c > =================================================================== > --- mmotm-2.6.33-Feb10.orig/mm/oom_kill.c > +++ mmotm-2.6.33-Feb10/mm/oom_kill.c > @@ -459,6 +459,8 @@ static int oom_kill_process(struct task_ > list_for_each_entry(c, &p->children, sibling) { > if (c->mm == p->mm) > continue; > + if (mem && !task_in_mem_cgroup(c, mem)) > + continue; > if (!oom_kill_task(c)) > return 0; > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org