From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id B92166B004D for ; Wed, 27 Jan 2010 16:46:50 -0500 (EST) From: Arnd Bergmann Subject: Re: [PATCH 01 of 31] define MADV_HUGEPAGE Date: Wed, 27 Jan 2010 22:44:47 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201001272244.47211.arnd@arndb.de> Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Andrea Arcangeli , linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Nick Piggin , Rik van Riel , Mel Gorman , Andi Kleen , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , Andrew Morton , bpicco@redhat.com, Christoph Hellwig , KOSAKI Motohiro List-ID: On Wednesday 27 January 2010, Hugh Dickins wrote: > So I think you should follow what we did with MADV_MERGEABLE: > define it in asm-generic/mman-common.h and the four arches, > use the expected number 14 wherever you can, and 67 for parisc. > > Or if you feel there's virtue in using the same number on all > arches (it would be less confusing, yes) and want to pave that way > (as we'd have better done with MADV_MERGEABLE), add a comment into > four of those files to point to parisc's peculiar group, and use > the same number 67 on all (perhaps via an asm-generic/madv-common.h). > > I'd take the lazy way out and follow what we did with MADV_MERGEABLE, > unless Arnd (Mr Asm-Generic) would prefer something else. I fully agree with using 14 in asm-generic and 67 in parisc. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org