From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id EB9F76B00A3 for ; Tue, 26 Jan 2010 13:38:43 -0500 (EST) Date: Tue, 26 Jan 2010 18:38:20 +0000 From: Mel Gorman Subject: Re: [PATCH 05 of 31] fix bad_page to show the real reason the page is bad Message-ID: <20100126183819.GJ16468@csn.ul.ie> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Andi Kleen , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , Andrew Morton , bpicco@redhat.com, Christoph Hellwig , KOSAKI Motohiro List-ID: On Tue, Jan 26, 2010 at 02:52:00PM +0100, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > page_count shows the count of the head page, but the actual check is done on > the tail page, so show what is really being checked. > > Signed-off-by: Andrea Arcangeli Acked-by: Mel Gorman > --- > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -265,7 +265,7 @@ static void bad_page(struct page *page) > current->comm, page_to_pfn(page)); > printk(KERN_ALERT > "page:%p flags:%p count:%d mapcount:%d mapping:%p index:%lx\n", > - page, (void *)page->flags, page_count(page), > + page, (void *)page->flags, atomic_read(&page->_count), > page_mapcount(page), page->mapping, page->index); > > dump_stack(); > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org