From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Zheng, Shaohui" <shaohui.zheng@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes
Date: Tue, 19 Jan 2010 09:38:56 +0900 (JST) [thread overview]
Message-ID: <20100119093646.5F2B.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100118134429.GD721@localhost>
> > > - return sprintf(buf, "%lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
> > > + return sprintf(buf, "%#lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
>
> > crappy changelog!
> >
> > Why this change? Perhaps showing us an example of the before-and-after
> > output would help us see what is being fixed, and why.
>
> Sorry for being late (some SMTP problem).
>
> # cat /sys/devices/system/memory/block_size_bytes
> before patch: 8000000
> after patch: 0x8000000
>
> This is a good fix because someone is very likely to mistake 8000000
> as a decimal number. 0x8000000 looks much better.
I'm sorry. NAK.
print_block_size() was introduced at 2005. So, we can't assume any
programs don't use it.
Your patch is good, but too late...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-01-19 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 11:59 Wu Fengguang
2010-01-14 12:04 ` [PATCH] sysdev: fix prototype for memory_sysdev_class show/store functions Wu Fengguang
2010-01-14 12:32 ` Andi Kleen
2010-01-18 13:07 ` Wu Fengguang
2010-01-20 2:23 ` Greg KH
2010-01-14 23:29 ` [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes Andrew Morton
2010-01-18 13:44 ` Wu Fengguang
2010-01-19 0:38 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119093646.5F2B.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox