From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "Zheng, Shaohui" <shaohui.zheng@intel.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"y-goto@jp.fujitsu.com" <y-goto@jp.fujitsu.com>,
Dave Hansen <haveblue@us.ibm.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel
Date: Tue, 12 Jan 2010 17:57:24 +0900 [thread overview]
Message-ID: <20100112175724.adfa04d6.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <DA586906BA1FFC4384FCFD6429ECE860316C01D6@shzsmsx502.ccr.corp.intel.com>
On Tue, 12 Jan 2010 16:57:40 +0800
"Zheng, Shaohui" <shaohui.zheng@intel.com> wrote:
>
> 3 points...
> 1. I think this patch cannot be compiled in archs other than x86. Right ?
> IOW, please add static inline dummy...
> [Zheng, Shaohui] Agree, I will add a static dummy function
>
> 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug.
> Please place the hook nearby them.
> [Zheng, Shaohui] Agree.
>
> 3. I recommend you yo use memory hotplug notifier.
> If it's allowed, it will be cleaner.
> It seems there are no strict ordering to update parameters this patch touches.
>
> [Zheng, Shaohui] Kame, do you means put the hook into function slab_mem_going_online_callback, it seems a good idea. If we select this method, we will need not to update these variable in function add_memory explicitly.
>
yes. I think callback is the best.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-12 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 7:45 Zheng, Shaohui
2010-01-12 8:04 ` KAMEZAWA Hiroyuki
2010-01-12 8:57 ` Zheng, Shaohui
2010-01-12 8:57 ` KAMEZAWA Hiroyuki [this message]
2010-01-12 9:05 ` Zheng, Shaohui
2010-01-12 13:17 ` Zheng, Shaohui
2010-01-14 13:24 ` Wu Fengguang
2010-01-14 14:08 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112175724.adfa04d6.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@intel.com \
--cc=x86@kernel.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox