Re: mmotm 2010-01-06-14-34 uploaded (mm/memcontrol)

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 7 Jan 2010 11:59:01 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> Thank you for your fix.
> 
> On Thu, 7 Jan 2010 11:21:50 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > On Thu, 7 Jan 2010 11:13:19 +0900
> > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > 
> > > Thank you for your report.
> >  
> > > > config attached.
> > > > 
> > > I'm sorry I missed the !CONFIG_SWAP or !CONFIG_CGROUP_MEM_RES_CTLR_SWAP case.
> > > 
> > > I'll prepare fixes.
> > > 
> > Nishimura-san, could you double check this ?
> > 
> It seems that this cannot fix the !CONFIG_SWAP case in my environment.
> 
> > Andrew, this is a fix onto Nishimura-san's memcg move account patch series.
> > Maybe this -> patches/memcg-move-charges-of-anonymous-swap.patch
> > 
> I think both memcg-move-charges-of-anonymous-swap.patch and
> memcg-improve-performance-in-moving-swap-charge.patch need to be fixed.
> 
> > mm/memcontrol.c: In function 'is_target_pte_for_mc':
> > mm/memcontrol.c:3985: error: implicit declaration of function 'mem_cgroup_count_swap_user'
> This derives from a bug of memcg-move-charges-of-anonymous-swap.patch,
> 
> and
> 
> > mm/memcontrol.c: In function 'mem_cgroup_move_charge_pte_range':
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account'
> this derives from that of memcg-improve-performance-in-moving-swap-charge.patch.
> 
> 
> I'm now testing my patch in some configs, and will post later.
> 
Okay, plz.

Thanks,
-Kame



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>