From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3771ED2E031 for ; Wed, 23 Oct 2024 09:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF09B6B0083; Wed, 23 Oct 2024 05:28:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA1206B0085; Wed, 23 Oct 2024 05:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F38B6B0096; Wed, 23 Oct 2024 05:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D8BA6B0083 for ; Wed, 23 Oct 2024 05:28:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91B15A07C7 for ; Wed, 23 Oct 2024 09:27:33 +0000 (UTC) X-FDA: 82704339984.21.22C4BAF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 1AD081C000C for ; Wed, 23 Oct 2024 09:27:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ephtVmF3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uQCpIMcu; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ephtVmF3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uQCpIMcu; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729675606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NXREPTQPvj+R0SDc4rLGub5W4H0S39MObup6CsugaA4=; b=gkwsN/OdCUbRIO2rdV0UgbFKhe1rG7lBGveixhVhqug9XR8e43JOHegf26e7ju18++TZVV Y5QGc2nV+gEHZRTF0mnCd15ArKlGDWLvFMS+3L/Om9ytOsTCXb+POnN9zAYz9cvu47coSN XbNWSaYA14EMeqP/w5Nvkl+4DDW/Hws= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ephtVmF3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uQCpIMcu; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ephtVmF3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uQCpIMcu; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729675606; a=rsa-sha256; cv=none; b=J1zAXD8yoGjclfdvVDr1KfwKX5xs9KQO4/1HkZbxhZrRQIe0bp/mqw0kYTgcSceK+lVQJI 1LTnxXtXMkmSc/EhTC/dfHeBvP8hmsJV8e6/fwaCkaywaj0H+DEpY5xo/8ilD0V59UJp2W z1W8XmYqm0Lj9P7TbiE/Th8nzu4pHN0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F4851FD91; Wed, 23 Oct 2024 09:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729675681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NXREPTQPvj+R0SDc4rLGub5W4H0S39MObup6CsugaA4=; b=ephtVmF3kCJJbOj/JEQU2YtU8OB6qtqwRHmBc5Tqj5+rAR3rb4ZII0dw8LXU0GwYuf86Nl Mw7JE2AublawUHMYzZFRVPdmnUQ+G+DHzqHI103DdOeHLiYLUEZOeYM1MO51KFycxElh9u HNkKxSX6mYhD5WZ6wG5QBn2j2uZWySo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729675681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NXREPTQPvj+R0SDc4rLGub5W4H0S39MObup6CsugaA4=; b=uQCpIMcuzO5hf7Nbs3RPo2Aawac8HUi4ONSOGAyto7Zlmo+147hfZBmmtXuyS+4R425LJy M9HotmzbQQurjuCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729675681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NXREPTQPvj+R0SDc4rLGub5W4H0S39MObup6CsugaA4=; b=ephtVmF3kCJJbOj/JEQU2YtU8OB6qtqwRHmBc5Tqj5+rAR3rb4ZII0dw8LXU0GwYuf86Nl Mw7JE2AublawUHMYzZFRVPdmnUQ+G+DHzqHI103DdOeHLiYLUEZOeYM1MO51KFycxElh9u HNkKxSX6mYhD5WZ6wG5QBn2j2uZWySo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729675681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NXREPTQPvj+R0SDc4rLGub5W4H0S39MObup6CsugaA4=; b=uQCpIMcuzO5hf7Nbs3RPo2Aawac8HUi4ONSOGAyto7Zlmo+147hfZBmmtXuyS+4R425LJy M9HotmzbQQurjuCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EE40E13A63; Wed, 23 Oct 2024 09:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PaTROaDBGGegLAAAD6G6ig (envelope-from ); Wed, 23 Oct 2024 09:28:00 +0000 Message-ID: <200f4eb7-f367-4020-ad44-382e3a24ee2a@suse.cz> Date: Wed, 23 Oct 2024 11:28:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/slab: fix a memory leak on kobject_init_and_add() failure Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org References: <20241021091413.154775-1-42.hyeyoo@gmail.com> <77d5c04b-9b97-4aee-85a9-c5efb2fa21fe@suse.cz> <439eed20-d0c7-8332-2f17-d785321d3310@gentwo.org> <059dead9-51c5-49b9-bbb9-5f3be741c830@suse.cz> <7e4978d7-7f93-5d30-bf2a-736b0e1e9ad4@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 1AD081C000C X-Stat-Signature: ifzd9xmfiiy63utkqp63af8euz39q34j X-HE-Tag: 1729675674-424973 X-HE-Meta: U2FsdGVkX1+UnEQ+Q4hHmp3HD/GWu8dXkBoktxhhlGcK8Fn9wxpOsSa4ldZUXuGsDN/A4kemdiUwla5PXhHJh++MlwVERYGJL6xgijzq6bEdnJzh++dTTyKAChmC3Q2om7rPbXCPAbobN89LdjYDkowK8vh3EyQ1kW6F/kNVFNxgupAENAkB9zmkWaBBMW8/t4ol2hT1DmZDc3yFpRcLHhSA8OsJHtclHcIR/t+vzSkRcJqADI9oQXkdi3SPe+l6zZW8Pe5sJ4ar/x+QHILPS4KuEYom4uM53BkBNsLOIGsh2eo9THdYvnc4Q6c8WxRp0M3z8ZXxp0hnXdlz2O+gKSOUgYJnR6t4AYMS3pZVPAml5Kvp1qJCUkMxhXvHHL38EBqJqRXPjEGIQMu+Q01gR/FNyRI3ZTUMWtHB4UFOVe3TOiFnx1ifXdtqsuyjERKSCxELgKlk3ljkfsxS0pfD0z9+9Ny2SzDZsi+sJOsNqBhJduWScs53JL0MHU6ojWlLFJYbKmLgq0GSJPGjWNwKS61FSMhO/yI+Z2ohHDeRI6HozPZLk3fiVV/LJ+EtFDE51cVfXesPiJqW5ca0JJ4GeSRN1EkAe844XrG+3MDJ3nY7GeMA86mJeDYqXug5LHBSzSBDlO1lwBh/9+ZhAYn1FzY0jovj6cJ+GLba7eiTV/5ag1apm3GjKGuSn0aM0LA5WOfIkH/FobSTAew/KMUz3ui2MG6HJXzQo5J8XUCoM/i0+w6Cl2Wv/44OoZQlyooXguuFK7v9dA9BpqoCHcU7k87ZglVd9vru1wDOAT3q0WUcpgOQcOOp7MOxi27o5Wcw/zy8x77hfRMPAysBMYagjGSIbI9Fhx1ZPdxM2Pl4GC3GjBCQ8O7PJN9gla0K3RSdbmPPPDchCUB5kWqruogH5lC3iImCnX4lCQRRYmI4T82DVir7caFHcZYXSZd3EPTzD5KlddtOxb0rINpYgyy GkfrOpSp oGr+HcT4GXkkXBIzHJWirgUkNdlefAiblEt9jSVNy3f+kaDEtd2AE0QY1PvabiAvXoSuYJTydrD3w54WhoInOodPkRtZxdvkDKtUcIiqSUG//0oXAV6jfQpLS/KznBr1uUCj8+nfERjb2uOxoK/KOEDe6vfwhIy2iesQ2wCycgzu6DqT3GSTUOkc0+NUEja5AiBRJF0EYeawJcRrDaJ9Hgyrfl4Xa3P+GxNHvjCvda0VgD5sPyF/XxKFk0Lbyh6AKz8Ja3/mBroMruLrqF/gBaBfJ4k3lQkOHfb+PcPZVdj1TG+Dt71W9Rdc9SUE2gqsgy88L7EM2arID0de8EX6FF5PUkw9pTfTnXLODq6VShvhnCR5jf8wsR7pf0zSVm/eoMMai8+RMbrSOt3yVjit93qTkPrgnTNAPWMdA3HUSJMJsjwRqHLPQ2s7bt9DrEThRaEtB1WdkQI2XbJukKkMD5NBVd0R7I+fJG3AGzeeKDMz8Xfc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/23/24 11:23, Hyeonggon Yoo wrote: > On Wed, Oct 23, 2024 at 1:08 AM Christoph Lameter (Ampere) > wrote: >> >> On Tue, 22 Oct 2024, Vlastimil Babka wrote: >> >> > On 10/21/24 18:27, Christoph Lameter (Ampere) wrote: >> > > On Mon, 21 Oct 2024, Vlastimil Babka wrote: >> > > >> > >> I think the comment "If this function returns an error, kobject_put() must >> > >> be called" means that *if* you want to destroy it due to the failure, you >> > >> must use kobject_put() and not e.g. kfree(). But IMHO it doesn't mean you >> > >> must destroy it because of the kobject_add() failure. >> > > >> > > Right. The simplest solution is to see the sysfs stuff as optional. If it >> > >> > To clarify, I only meant the case of boot caches processed for sysfs later. >> > I don't think we need to start ignoring all sysfs errors. >> >> Well not ignoring. Write something to the syslog. So it wont affect slab >> operations. /sys support is not critical to the slab subsystem operations >> and is often not used at all. >> >> If its conks out then it should be fixed but it should not impact current >> operations. We have had so many issues with sysfs support in the past that >> doing so would be wise to avoid future problems. > > Both directions look fine to me. Christoph's approach would probably be better > for maintainability I think? Failing to create sysfs files is not a > critical problem anyway. Yeah I guess, if it makes things simpler... Feel free to do that as v2 then!