From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id A4D2760021B for ; Mon, 28 Dec 2009 00:33:56 -0500 (EST) Received: by yxe10 with SMTP id 10so5439905yxe.12 for ; Sun, 27 Dec 2009 21:33:54 -0800 (PST) Date: Mon, 28 Dec 2009 14:31:54 +0900 From: Minchan Kim Subject: Re: [PATCH -mmotm-2009-12-10-17-19] Fix wrong rss count of smaps Message-Id: <20091228143154.ec0431b5.minchan.kim@barrios-desktop> In-Reply-To: <20091228134752.44d13c34.kamezawa.hiroyu@jp.fujitsu.com> References: <20091228134619.92ba28f6.minchan.kim@barrios-desktop> <20091228134752.44d13c34.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Minchan Kim , Andrew Morton , lkml , linux-mm , Matt Mackall , Hugh Dickins List-ID: Hi, Kame. On Mon, 28 Dec 2009 13:47:52 +0900 KAMEZAWA Hiroyuki wrote: > On Mon, 28 Dec 2009 13:46:19 +0900 > Minchan Kim wrote: > > > > > I am not sure we have to account zero page with file_rss. > > Hugh and Kame's new zero page doesn't do it. > > As side effect of this, we can prevent innocent process which have a lot > > of zero page when OOM happens. > > (But I am not sure there is a process like this :) > > So I think not file_rss counting is not bad. > > > > RSS counting zero page with file_rss helps any program using smaps? > > If we have to keep the old behavior, I have to remake this patch. > > > > == CUT_HERE == > > > > Long time ago, We regards zero page as file_rss and > > vm_normal_page doesn't return NULL. > > > > But now, we reinstated ZERO_PAGE and vm_normal_page's implementation > > can return NULL in case of zero page. Also we don't count it with > > file_rss any more. > > > > Then, RSS and PSS can't be matched. > > For consistency, Let's ignore zero page in smaps_pte_range. > > > > CC: Matt Mackall > > Signed-off-by: Minchan Kim > > Acked-by: KAMEZAWA Hiroyuki Thanks for ACK. :) > > BTW, how about counting ZERO page in smaps? Ignoring them completely sounds > not very good. I am not use it is useful. zero page snapshot of ongoing process is useful? Doesn't Admin need to know about zero page? Let's admins use it well. If we remove zero page again? How many are applications use smaps? Did we have a problem without it? When I think of it, there are too many qeustions. Most important thing to add new statistics is just need of customer. Frankly speaking, I don't have good scenario of using zero page. Do you have any scenario it is valueable? > > Thanks, > -Kame -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org