From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 35A10620002 for ; Thu, 24 Dec 2009 23:24:16 -0500 (EST) Date: Fri, 25 Dec 2009 13:17:00 +0900 From: Daisuke Nishimura Subject: Re: [PATCH 28 of 28] memcg huge memory Message-Id: <20091225131700.3db3fb4f.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20091221133315.7d21ccae.nishimura@mxp.nes.nec.co.jp> References: <20091218103312.2f61bbfc.kamezawa.hiroyu@jp.fujitsu.com> <20091218160437.GP29790@random.random> <20091220183943.GA6429@random.random> <20091221092625.4aef2c3a.kamezawa.hiroyu@jp.fujitsu.com> <20091221102427.8b22467f.nishimura@mxp.nes.nec.co.jp> <20091221125223.4ae56520.kamezawa.hiroyu@jp.fujitsu.com> <20091221133315.7d21ccae.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Andrea Arcangeli , linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Mel Gorman , Andi Kleen , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , Christoph Lameter , Chris Wright , Andrew Morton , Daisuke Nishimura List-ID: On Mon, 21 Dec 2009 13:33:15 +0900, Daisuke Nishimura wrote: > On Mon, 21 Dec 2009 12:52:23 +0900, KAMEZAWA Hiroyuki wrote: > > On Mon, 21 Dec 2009 10:24:27 +0900 > > Daisuke Nishimura wrote: > > > > > On Mon, 21 Dec 2009 09:26:25 +0900, KAMEZAWA Hiroyuki wrote: > > > > Added CC: to Nishimura. > > > > > > > > Andrea, Please go ahead as you like. My only concern is a confliction with > > > > Nishimura's work. > > > I agree. I've already noticed Andrea's patches but not read through all the > > > patches yet, sorry. > > > > > > One concern: isn't there any inconsistency to handle css->refcnt in charging/uncharging > > > compound pages the same way as a normal page ? > > > > > AKAIK, no inconsistency. > O.K. thanks. > (It might be better for us to remove per page css refcnt till 2.6.34...) > Hmm, if I understand these patches correctly, some inconsistency about css->refcnt and page_cgroup of tail pages happen when a huge page is splitted. At least, I think pc->flags and pc->mem_cgroup of them should be handled. So, I think we need some hooks in __split_huge_page_map() or some tricks. > > My biggest concern is that page-table-walker has to handle hugepages. > > > Ah, you're right. > It would be a big change.. > In [19/28] of this version, split_huge_page_mm() is called in walk_pmd_range(). So, I think it will work w/o changing current code. (It might be better to change my code, which does all the works in walk->pmd_entry(), to prevent unnecessary splitting.) Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org