Re: [PATCH -mmotm 4/8] memcg: move charges of anonymous page

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Mon, 21 Dec 2009 14:35:03 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> This patch is the core part of this move-charge-at-task-migration feature.
> It implements functions to move charges of anonymous pages mapped only by
> the target task.
> 
> Implementation:
> - define struct move_charge_struct and a valuable of it(mc) to remember the
>   count of pre-charges and other information.
> - At can_attach(), get anon_rss of the target mm, call __mem_cgroup_try_charge()
>   repeatedly and count up mc.precharge.
> - At attach(), parse the page table, find a target page to be move, and call
>   mem_cgroup_move_account() about the page.
> - Cancel all precharges if mc.precharge > 0 on failure or at the end of
>   task move.
> 
> Changelog: 2009/12/04
> - change the term "recharge" to "move_charge".
> - handle a signal in can_attach() phase.
> - parse the page table in can_attach() phase again(go back to the old behavior),
>   because it doesn't add so big overheads, so it would be better to calculate
>   the precharge count more accurately.
> Changelog: 2009/11/19
> - in can_attach(), instead of parsing the page table, make use of per process
>   mm_counter(anon_rss).
> - loosen the valid check in is_target_pte_for_recharge().
> Changelog: 2009/11/06
> - drop support for file cache, shmem/tmpfs and shared(used by multiple processes)
>   pages(revisit in future).
> Changelog: 2009/10/13
> - change the term "migrate" to "recharge".
> Changelog: 2009/09/24
> - in can_attach(), parse the page table of the task and count only the number
>   of target ptes and call try_charge() repeatedly. No isolation at this phase.
> - in attach(), parse the page table of the task again, and isolate the target
>   page and call move_account() one by one.
> 
> Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>