From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id D2AF06B0044 for ; Wed, 16 Dec 2009 18:13:35 -0500 (EST) Date: Wed, 16 Dec 2009 15:12:10 -0800 From: Greg KH Subject: Re: [stable] [PATCH -stable] vmalloc: conditionalize build of pcpu_get_vm_areas() Message-ID: <20091216231210.GB9421@kroah.com> References: <4B1D3A3302000078000241CD@vpn.id2.novell.com> <20091207153552.0fadf335.akpm@linux-foundation.org> <4B1E1B1B0200007800024345@vpn.id2.novell.com> <4B1E0E56.8020003@kernel.org> <4B1E1EE60200007800024364@vpn.id2.novell.com> <4B1E1513.3020000@kernel.org> <4B203614.1010907@novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B203614.1010907@novell.com> Sender: owner-linux-mm@kvack.org To: Tejun Heo Cc: stable@kernel.org, tony.luck@intel.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Beulich , linux-mm@kvack.org, Geert Uytterhoeven , Andrew Morton List-ID: On Thu, Dec 10, 2009 at 08:43:16AM +0900, Tejun Heo wrote: > pcpu_get_vm_areas() is used only when dynamic percpu allocator is used > by the architecture. In 2.6.32, ia64 doesn't use dynamic percpu > allocator and has a macro which makes pcpu_get_vm_areas() buggy via > local/global variable aliasing and triggers compile warning. > > The problem is fixed in upstream and ia64 uses dynamic percpu > allocators, so the only left issue is inclusion of unnecessary code > and compile warning on ia64 on 2.6.32. > > Don't build pcpu_get_vm_areas() if legacy percpu allocator is in use. > > Signed-off-by: Tejun Heo > Reported-by: Jan Beulich > Cc: stable@kernel.org > --- > Please note that this commit won't appear on upstream. So this is only needed for the .32 kernel stable tree? Not .31? And it's not upstream as it was solved differently there? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org