From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 00E4D6B0044 for ; Mon, 14 Dec 2009 23:46:31 -0500 (EST) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nBF4kTaj016210 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 15 Dec 2009 13:46:29 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 20EBA45DE4E for ; Tue, 15 Dec 2009 13:46:29 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id E92C845DE4D for ; Tue, 15 Dec 2009 13:46:28 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id D73421DB803F for ; Tue, 15 Dec 2009 13:46:28 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 8F4F71DB803C for ; Tue, 15 Dec 2009 13:46:28 +0900 (JST) Date: Tue, 15 Dec 2009 13:43:27 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v4.2 Message-Id: <20091215134327.6c46b586.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20091110162121.361B.A69D9226@jp.fujitsu.com> <20091110170338.9f3bb417.nishimura@mxp.nes.nec.co.jp> <20091110171704.3800f081.kamezawa.hiroyu@jp.fujitsu.com> <20091111112404.0026e601.kamezawa.hiroyu@jp.fujitsu.com> <20091111134514.4edd3011.kamezawa.hiroyu@jp.fujitsu.com> <20091111142811.eb16f062.kamezawa.hiroyu@jp.fujitsu.com> <20091111152004.3d585cee.kamezawa.hiroyu@jp.fujitsu.com> <20091111153414.3c263842.kamezawa.hiroyu@jp.fujitsu.com> <20091118095824.076c211f.kamezawa.hiroyu@jp.fujitsu.com> <20091214171632.0b34d833.akpm@linux-foundation.org> <20091215103202.eacfd64e.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Andrew Morton , Daisuke Nishimura , KOSAKI Motohiro , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter List-ID: On Mon, 14 Dec 2009 20:30:37 -0800 (PST) David Rientjes wrote: > On Tue, 15 Dec 2009, KAMEZAWA Hiroyuki wrote: > > > I'm now preparing more counters for mm's statistics. It's better to > > wait and to see what we can do more. And other patches for total > > oom-killer improvement is under development. > > > > And, there is a compatibility problem. > > As David says, this may break some crazy software which uses > > fake_numa+cpuset+oom_killer+oom_adj for resource controlling. > > (even if I recommend them to use memcg rather than crazy tricks...) > > > > That's not at all what I said. I said using total_vm as a baseline allows > users to define when a process is to be considered "rogue," that is, using > more memory than expected. Using rss would be inappropriate since it is > highly dynamic and depends on the state of the VM at the time of oom, > which userspace cannot possibly keep updated. > > You consistently ignore that point: the power of /proc/pid/oom_adj to > influence when a process, such as a memory leaker, is to be considered as > a high priority for an oom kill. It has absolutely nothing to do with > fake NUMA, cpusets, or memcg. > You also ignore that it's not sane to use oom kill for resource control ;) Anyway, rss patch was dropped as you want. I'll prepare other ones. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org