From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id CC6E86B0044 for ; Mon, 14 Dec 2009 20:35:20 -0500 (EST) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nBF1ZIFX010383 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 15 Dec 2009 10:35:18 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id CCDBC45DE59 for ; Tue, 15 Dec 2009 10:35:16 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 920B145DE53 for ; Tue, 15 Dec 2009 10:35:16 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id A9165E78002 for ; Tue, 15 Dec 2009 10:35:15 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 7CD751DB8037 for ; Tue, 15 Dec 2009 10:35:14 +0900 (JST) Date: Tue, 15 Dec 2009 10:32:02 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v4.2 Message-Id: <20091215103202.eacfd64e.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20091214171632.0b34d833.akpm@linux-foundation.org> References: <20091110162121.361B.A69D9226@jp.fujitsu.com> <20091110162445.c6db7521.kamezawa.hiroyu@jp.fujitsu.com> <20091110163419.361E.A69D9226@jp.fujitsu.com> <20091110164055.a1b44a4b.kamezawa.hiroyu@jp.fujitsu.com> <20091110170338.9f3bb417.nishimura@mxp.nes.nec.co.jp> <20091110171704.3800f081.kamezawa.hiroyu@jp.fujitsu.com> <20091111112404.0026e601.kamezawa.hiroyu@jp.fujitsu.com> <20091111134514.4edd3011.kamezawa.hiroyu@jp.fujitsu.com> <20091111142811.eb16f062.kamezawa.hiroyu@jp.fujitsu.com> <20091111152004.3d585cee.kamezawa.hiroyu@jp.fujitsu.com> <20091111153414.3c263842.kamezawa.hiroyu@jp.fujitsu.com> <20091118095824.076c211f.kamezawa.hiroyu@jp.fujitsu.com> <20091214171632.0b34d833.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: David Rientjes , Daisuke Nishimura , KOSAKI Motohiro , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter List-ID: On Mon, 14 Dec 2009 17:16:32 -0800 Andrew Morton wrote: > > So I have a note-to-self here that these patches: > > oom_kill-use-rss-value-instead-of-vm-size-for-badness.patch > oom-kill-show-virtual-size-and-rss-information-of-the-killed-process.patch > oom-kill-fix-numa-consraint-check-with-nodemask-v42.patch > > are tentative and it was unclear whether I should merge them. > > What do we think? > In my view, oom-kill-show-virtual-size-and-rss-information-of-the-killed-process.patch - should be merged. Because we tend to get several OOM reports in a month, More precise information is always welcomed. oom-kill-fix-numa-consraint-check-with-nodemask-v42.patch - should be merged. This is a bug fix. oom_kill-use-rss-value-instead-of-vm-size-for-badness.patch - should not be merged. I'm now preparing more counters for mm's statistics. It's better to wait and to see what we can do more. And other patches for total oom-killer improvement is under development. And, there is a compatibility problem. As David says, this may break some crazy software which uses fake_numa+cpuset+oom_killer+oom_adj for resource controlling. (even if I recommend them to use memcg rather than crazy tricks...) 2 ideas which I can think of now are.. 1) add sysctl_oom_calc_on_committed_memory If this is set, use vm-size instead of rss. 2) add /proc//oom_guard_size This allows users to specify "valid/expected size" of a task. When #echo 10M > /proc//oom_guard_size At OOM calculation, 10Mbytes is subtracted from rss size. (The best way is to estimate this automatically from vm_size..but...) Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org