linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: lwoodman@redhat.com
Cc: kosaki.motohiro@jp.fujitsu.com,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [RFC][PATCH v2  4/8] Replace page_referenced() with wipe_page_reference()
Date: Fri, 11 Dec 2009 08:46:25 +0900 (JST)	[thread overview]
Message-ID: <20091211082410.257D.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <4B20EF88.7050402@redhat.com>

> KOSAKI Motohiro wrote:
> > @@ -578,7 +577,9 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> >
> > +		struct page_reference_context refctx = {
> > +			.is_page_locked = 1,
> >
> >   *
> > @@ -1289,7 +1291,6 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> >
> > +		struct page_reference_context refctx = {
> > +			.is_page_locked = 0,
> > +		};
> > +
> >   
> are these whole structs properly initialized on the kernel stack?

Yes. C spec says

3.5.7 Initialization

Syntax

          initializer:
                  assignment-expression
                  {  initializer-list } 
                  {  initializer-list , }

          initializer-list:
                  initializer
                  initializer-list ,  initializer
(snip)

   If there are fewer initializers in a list than there are members of
an aggregate, the remainder of the aggregate shall be initialized
implicitly the same as objects that have static storage duration.

Referenced to
  Draft ANSI C Standard (ANSI X3J11/88-090) (May 13, 1988) http://flash-gordon.me.uk/ansi.c.txt


Probably, google "{0}" help your understand to initializer in C.




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-12-10 23:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10  7:28 [RFC][PATCH v2 0/8] vmscan: AIM7 scalability improvement KOSAKI Motohiro
2009-12-10  7:29 ` [RFC][PATCH v2 1/8] Replace page_mapping_inuse() with page_mapped() KOSAKI Motohiro
2009-12-10  7:30 ` [RFC][PATCH v2 2/8] Introduce __page_check_address KOSAKI Motohiro
2009-12-10  7:31 ` [RFC][PATCH v2 3/8] VM_LOCKED check don't need pte lock KOSAKI Motohiro
2009-12-10  7:32 ` [RFC][PATCH v2 4/8] Replace page_referenced() with wipe_page_reference() KOSAKI Motohiro
2009-12-10 12:54   ` Larry Woodman
2009-12-10 23:46     ` KOSAKI Motohiro [this message]
2009-12-10  7:32 ` [RFC][PATCH v2 5/8] Don't deactivate the page if trylock_page() is failed KOSAKI Motohiro
2009-12-10  7:33 ` [RFC][PATCH v2 6/8] wipe_page_reference return SWAP_AGAIN if VM pressulre is low and lock contention is detected KOSAKI Motohiro
2009-12-10  7:34 ` [RFC][PATCH v2 7/8] Try to mark PG_mlocked if wipe_page_reference find VM_LOCKED vma KOSAKI Motohiro
2009-12-10  7:35 ` [RFC][PATCH v2 8/8] Don't deactivate many touched page KOSAKI Motohiro
2009-12-11  2:11   ` Minchan Kim
2009-12-10  7:53 ` [RFC][PATCH v2 0/8] vmscan: AIM7 scalability improvement KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211082410.257D.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox